Skip to content

fix(renovate): drop followTag on retired v1 floating tag - #205

Merged
williaby merged 4 commits into
mainfrom
claude/retire-followtag-v1-0
Oct 3, 2026
Merged

williaby merged 4 commits into
mainfrom
claude/retire-followtag-v1-0

Conversation

@williaby

@williaby williaby commented Jul 2, 2026 •

Copy link
Copy Markdown
Owner

Removes followTag: "v1" from the org-workflow Renovate rule. The org tag-protection ruleset forbids re-pointing v* tags, so v1 froze at the v1.1.0 commit and the followed tag silently froze all org-workflow SHA-pin updates. Plain semver tracking of the immutable vX.Y.Z release tags restores update delivery.

Companion to ByronWilliamsCPA/.github#244 (v1 tag retirement) and ByronWilliamsCPA/.claude#251 (CI-057 inversion). Satisfies the inverted CI-057.

Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated automated versioning for GitHub Actions references to follow semantic version releases.
    • Updates now advance SHA pins to immutable release tags; floating major tags are no longer used.

Copilot AI review requested due to automatic review settings July 2, 2026 17:43
@williaby
williaby enabled auto-merge (squash) July 2, 2026 17:43

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes Renovate’s followTag: "v1" behavior for the org reusable-workflow rule so SHA pin updates resume by tracking immutable semver release tags (vX.Y.Z) instead of a frozen floating major tag.

Changes:

  • Dropped followTag: "v1" from the github-actions package rule that tracks org reusable workflows.
  • Updated the rule description to document why followTag must not be used given tag-protection immutability.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@coderabbitai

coderabbitai Bot commented Jul 2, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: williaby/image-preprocessing-detector/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Essentials

Run ID: 65c95a5c-8630-45ca-ba2e-1cb70bbbd296

📥 Commits

Reviewing files that changed from the base of the PR and between 7ce0b6d and 04e8a46.

📒 Files selected for processing (1)
  • renovate.json

Included review availability: This review used your included allowance. 2 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 3 reviews per hour.


Walkthrough

The GitHub Actions rule in renovate.json now matches two package names with matchPackageNames. It retains semver versioning, removes followTag: "v1", and updates the description to state that version tags are immutable and no floating major tag exists.

Changes

Renovate Configuration Update

Layer / File(s) Summary
Update versioning strategy for GitHub Actions pin rule
renovate.json
Uses matchPackageNames for the two packages, retains versioning: "semver", removes followTag: "v1", and updates the description to refer to immutable vX.Y.Z tags and the absence of a floating major tag.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 04e8a

This change switches Renovate from following the stale v1 tag to tracking semver release tags, with the aim of resuming SHA-pin updates. No concrete merge-blocking risk is evidenced; it is ready for normal checks.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: removing the retired followTag: "v1" setting from the Renovate configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

I’m a rabbit, pleased to see,
Semver tags for SHA pins, neatly,
Two package names match the rule,
No floating major tag to fool,
I nibble carrots and celebrate! 🐇

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

sonarqubecloud Bot commented Jul 2, 2026

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@renovate.json`:
- Around line 186-189: The Renovate rule still uses the legacy
matchPackagePatterns matcher, so update this config block to use
matchPackageNames instead. Keep the same package matching behavior for the
existing ByronWilliamsCPA/.github and williaby/.github entries, and make the
change in the relevant Renovate rule so it aligns with newer matcher support.
- Line 190: Update the Renovate rule for GitHub Actions to rely on the built-in
github-actions versioning instead of explicitly setting versioning to semver,
since that package rule should use the default scheme for immutable vX.Y.Z tags.
Also change the matcher from matchPackagePatterns to matchPackageNames in the
same rule so it uses the current supported field; look for the relevant
packageRule in renovate.json.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: c3075758-f72d-48ca-bea6-01557c1eaff2

📥 Commits

Reviewing files that changed from the base of the PR and between 9f83f0d and 7ce0b6d.

📒 Files selected for processing (1)
  • renovate.json

Comment thread renovate.json Resolved
Comment thread renovate.json Resolved
The org tag-protection ruleset forbids re-pointing v* tags, so the
floating v1 tag froze at the v1.1.0 commit; followTag "v1" therefore
froze all org-workflow SHA-pin updates at v1.1.0-era code. Plain semver
tracking of the immutable vX.Y.Z release tags (cut on every push to the
source repo's main) restores update delivery.

Companion to ByronWilliamsCPA/.github#244 and ByronWilliamsCPA/.claude#251
(CI-057 inversion).
@williaby
williaby force-pushed the claude/retire-followtag-v1-0 branch from 7ce0b6d to 14d7f2c Compare September 4, 2026 15:44
@williaby
williaby disabled auto-merge October 2, 2026 19:13
williaby and others added 2 commits October 2, 2026 12:14
…ames

Address CodeRabbit finding on PR #205: the org-workflow Renovate rule used
the deprecated matchPackagePatterns matcher. matchPackageNames matches the
two literal package names exactly (no regex dot ambiguity) and is
consistent with the other rules in renovate.json. Validated with
renovate-config-validator.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings October 2, 2026 19:14

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@sonarqubecloud

sonarqubecloud Bot commented Oct 2, 2026

Copy link
Copy Markdown

@williaby
williaby merged commit 66f9dcf into main Oct 3, 2026
33 checks passed
@williaby
williaby deleted the claude/retire-followtag-v1-0 branch October 3, 2026 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants