Repository navigation
fix(renovate): drop followTag on retired v1 floating tag - #205
Conversation
There was a problem hiding this comment.
Pull request overview
Removes Renovate’s followTag: "v1" behavior for the org reusable-workflow rule so SHA pin updates resume by tracking immutable semver release tags (vX.Y.Z) instead of a frozen floating major tag.
Changes:
- Dropped
followTag: "v1"from thegithub-actionspackage rule that tracks org reusable workflows. - Updated the rule description to document why
followTagmust not be used given tag-protection immutability.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: williaby/image-preprocessing-detector/.coderabbit.yaml Review profile: ASSERTIVE Plan: Essentials Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. 2 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 3 reviews per hour. WalkthroughThe GitHub Actions rule in ChangesRenovate Configuration Update
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to This change switches Renovate from following the stale 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
I’m a rabbit, pleased to see, Comment |
|
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@renovate.json`:
- Around line 186-189: The Renovate rule still uses the legacy
matchPackagePatterns matcher, so update this config block to use
matchPackageNames instead. Keep the same package matching behavior for the
existing ByronWilliamsCPA/.github and williaby/.github entries, and make the
change in the relevant Renovate rule so it aligns with newer matcher support.
- Line 190: Update the Renovate rule for GitHub Actions to rely on the built-in
github-actions versioning instead of explicitly setting versioning to semver,
since that package rule should use the default scheme for immutable vX.Y.Z tags.
Also change the matcher from matchPackagePatterns to matchPackageNames in the
same rule so it uses the current supported field; look for the relevant
packageRule in renovate.json.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: c3075758-f72d-48ca-bea6-01557c1eaff2
📒 Files selected for processing (1)
renovate.json
The org tag-protection ruleset forbids re-pointing v* tags, so the floating v1 tag froze at the v1.1.0 commit; followTag "v1" therefore froze all org-workflow SHA-pin updates at v1.1.0-era code. Plain semver tracking of the immutable vX.Y.Z release tags (cut on every push to the source repo's main) restores update delivery. Companion to ByronWilliamsCPA/.github#244 and ByronWilliamsCPA/.claude#251 (CI-057 inversion).
7ce0b6d to
14d7f2c
Compare
…ames Address CodeRabbit finding on PR #205: the org-workflow Renovate rule used the deprecated matchPackagePatterns matcher. matchPackageNames matches the two literal package names exactly (no regex dot ambiguity) and is consistent with the other rules in renovate.json. Validated with renovate-config-validator. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|



Removes
followTag: "v1"from the org-workflow Renovate rule. The org tag-protection ruleset forbids re-pointingv*tags, sov1froze at the v1.1.0 commit and the followed tag silently froze all org-workflow SHA-pin updates. Plain semver tracking of the immutablevX.Y.Zrelease tags restores update delivery.Companion to ByronWilliamsCPA/.github#244 (v1 tag retirement) and ByronWilliamsCPA/.claude#251 (CI-057 inversion). Satisfies the inverted CI-057.
Generated with Claude Code
Summary by CodeRabbit