Skip to content

feat(plugins): add basic message construction#5754

Merged
Mm2PL merged 26 commits intoChatterino:masterfrom
Nerixyz:feat/basic-plugin-message
Jul 31, 2025
Merged

feat(plugins): add basic message construction#5754
Mm2PL merged 26 commits intoChatterino:masterfrom
Nerixyz:feat/basic-plugin-message

Conversation

@Nerixyz
Copy link
Copy Markdown
Contributor

@Nerixyz Nerixyz commented Dec 5, 2024

This adds the API I described in #4999 (comment). There are minor differences (e.g. flags belong to a specific element). Some helper functions aren't there yet. This is only the bare-bones construction.

The /hello-world example works with this implementation.

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment thread src/controllers/plugins/api/ChannelRef.hpp
Comment thread src/controllers/plugins/api/Message.cpp Outdated
@Nerixyz Nerixyz marked this pull request as ready for review December 8, 2024 18:25
Copy link
Copy Markdown
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nits, other than that this looks good.
Thank you!

Comment thread src/controllers/plugins/PluginController.cpp Outdated
Comment thread src/controllers/plugins/api/ChannelRef.cpp Outdated
@pajlada pajlada requested a review from Mm2PL May 10, 2025 12:19
Copy link
Copy Markdown
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mm2PL merge this in when you've had a chance to take a look at it & you're happy with it

Copy link
Copy Markdown
Collaborator

@Mm2PL Mm2PL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few kinks to iron out, however the PR is looking pretty solid. Please update docs/wip-plugins.md.

Comment thread docs/plugin-meta.lua Outdated
Comment thread scripts/make_luals_meta.py
Comment thread src/controllers/plugins/api/Message.cpp Outdated
Comment thread src/controllers/plugins/api/Message.cpp
Comment thread src/controllers/plugins/api/Message.cpp
Comment thread src/controllers/plugins/api/Message.cpp Outdated
Comment thread src/controllers/plugins/api/Message.cpp Outdated
Comment thread src/controllers/plugins/api/Message.cpp Outdated
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment thread src/controllers/plugins/SolTypes.cpp Outdated
@Nerixyz Nerixyz force-pushed the feat/basic-plugin-message branch from 962bd1d to 204b187 Compare July 28, 2025 11:58
@Mm2PL Mm2PL merged commit a447874 into Chatterino:master Jul 31, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants