feat(plugins): allow message introspection#6353
Merged
Mm2PL merged 27 commits intoChatterino:masterfrom Dec 7, 2025
Merged
Conversation
Nerixyz
force-pushed
the
feat/message-introspection
branch
from
fdfa3c6 to
6140f6a
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Mm2PL
reviewed
Aug 9, 2025
pajlada
requested changes
Aug 9, 2025
Contributor
Author
|
I refactored the access for message elements. If a property for a message element doesn't exist, we now return |
pajlada
requested changes
Aug 10, 2025
Member
pajlada
left a comment
pajlada
left a comment
There was a problem hiding this comment.
just mini nit, otherwise looks good
pajlada
approved these changes
Aug 10, 2025
Member
|
@Mm2PL feel free to merge this in when you've taken a look / tested it / you're happy with it |
Mm2PL
requested changes
Dec 5, 2025
Collaborator
Mm2PL
left a comment
Mm2PL
left a comment
There was a problem hiding this comment.
Looks mostly good, just a couple nit picks. Please update the prose documentation to at least mention:
- that introspection is now possible
- that a concept of freezing a message exists
- liquid messages may be modified
Mm2PL
approved these changes
Dec 7, 2025
| } | ||
| else | ||
| { | ||
| return visitOne<TReturn, Rest...>( |
Contributor
There was a problem hiding this comment.
warning: use explicit 'this->' for member access [chatterino-explicit-this]
Suggested change
| return visitOne<TReturn, Rest...>( | |
| return this->visitOne<TReturn, Rest...>( |
| bool firstIteration = true; | ||
| for (Word &word : this->words_) | ||
| for (const auto &word : this->words_) | ||
| { |
Contributor
There was a problem hiding this comment.
warning: c++11 range-loop might detach Qt container (QStringList) [clazy-range-loop-detach]
Suggested change
| { | |
| ; | |
| )std::as_const(this->words_) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #5754. This allows users to introspect messages (i.e. look at the elements they're made up of).
The fields of messages are modifiable. Plugins can also add/remove elements. To allow Lua access to elements, they are wrapped in a custom iterator that keeps a reference to the original message. The fields of elements are mostly static right now. But it would be possible to allow modification.
A future feature could allow plugins to clone messages, which would then be modifiable again.