feat: dynamically track mutability of messages#6367
Merged
Mm2PL merged 5 commits intoChatterino:masterfrom Aug 4, 2025
Merged
Conversation
pajlada
approved these changes
Aug 2, 2025
Mm2PL
requested changes
Aug 4, 2025
Collaborator
Mm2PL
left a comment
Mm2PL
left a comment
There was a problem hiding this comment.
Code seems good. I just want some more clarification in the comment
Mm2PL
approved these changes
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a flag to
Message(frozen) that indicates that it shouldn't be modified anymore. This is set once it gets added to a channel.Why?
Plugins (#6353). Consider the following:
msgmsgto some channelmsgor modify it in some other wayWe don't allow this because we assume messages are immutable (except flags) once they're in a channel. Technically, this is also possible in C++. We can't enforce this statically - mutable messages are
std::shared_ptr<Message>and immutable ones arestd::shared_ptr<const Message>. There can be const and non-const pointers to the same message at the same time.In Lua, we need to check this invariant.