Skip to content

[chore]: CI - Check CFBundleShortVersionString in Info.plist #1006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 21, 2023

Conversation

lukepistrol
Copy link
Member

@lukepistrol lukepistrol commented Jan 20, 2023

Description

This PR implements an additional check in the Tests workflow to ensure that the manual set CFBundleShortVersionString is actually present in Info.plist.

This is just a sanity check which helps us catch this unexpected Xcode behavior as early as possible.

Background

The background of this is, that a couple versions back Xcode moved from having a dedicated Info.plist to embedding it into the Target settings. This sometimes causes the deletion of an explicitly set CFBundleShortVersionString key in the dedicated Info.plist file.

Fix "No version number found" Error

In order to resolve this issue simply add the following to the CodeEdit/Info.plist file:

<key>CFBundleShortVersionString</key>
<string>0.0.1</string>

The important part is to add it to the CodeEdit/Info.plist file instead of selecting the target and using the Info tab.

Additional Changes

  • disable Info.plist file generation (use the dedicated file instead)
  • migrated all Info properties to static Info.plist file
  • use xcconfig for copyright string

0xWDG
0xWDG previously approved these changes Jan 20, 2023
@lukepistrol lukepistrol enabled auto-merge (squash) January 20, 2023 15:43
@lukepistrol lukepistrol disabled auto-merge January 20, 2023 15:59
@lukepistrol lukepistrol marked this pull request as draft January 20, 2023 15:59
@lukepistrol lukepistrol marked this pull request as ready for review January 20, 2023 16:36
@lukepistrol lukepistrol requested a review from 0xWDG January 20, 2023 16:36
@lukepistrol lukepistrol merged commit fd2c961 into CodeEditApp:main Jan 21, 2023
@lukepistrol lukepistrol deleted the ci/add-app-version-check branch January 21, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants