Skip to content

[chore]: CI - Check CFBundleShortVersionString in Info.plist #1006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 21, 2023
Merged

[chore]: CI - Check CFBundleShortVersionString in Info.plist #1006

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3bf5a99
add check that CFBundleShortVersionString exists in Info.plist
lukepistrol Jan 20, 2023
3708fe6
fix naming, add PR reference
lukepistrol Jan 20, 2023
6ba74ac
add comments to script
lukepistrol Jan 20, 2023
14d3b8d
move to non generated Info.plist file
lukepistrol Jan 20, 2023
a24fd01
add copyright to xcconfigs
lukepistrol Jan 20, 2023
7881a4c
migrate to non-generated Info.plist for remaining targets
lukepistrol Jan 20, 2023
fc112c8
Merge branch 'ci/test-removing-info-plist-generation' into ci/add-app…
lukepistrol Jan 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions .github/scripts/test_version_number.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
#!/bin/bash

# get the version number from the Info.plist file using agvtool
VERS=$(xcrun agvtool mvers -terse1)

# if the version number is empty, exit with an error
if [ "$VERS" == "" ]; then
echo "No version number found"
echo "Make sure Info.plist has a CFBundleShortVersionString key"
echo ""
echo "If Info.plist does not have a CFBundleShortVersionString key, add the following to your Info.plist file:"
echo ""
echo "<key>CFBundleShortVersionString</key>"
echo "<string>0.0.1</string>"
echo ""
echo "For more information see https://github.com/CodeEditApp/CodeEdit/pull/1006"
exit 1 # exit with an error
else
echo "Version number is $VERS"
exit 0 # exit with no error
fi
2 changes: 2 additions & 0 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,7 @@ jobs:
steps:
- name: Checkout repository
uses: actions/checkout@v3
- name: Check Version Number exists
run: exec ./.github/scripts/test_version_number.sh
- name: Testing App
run: exec ./.github/scripts/test_app.sh arm