Skip to content

Support shadow root #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 5, 2025
Merged

Support shadow root #617

merged 9 commits into from
May 5, 2025

Conversation

CGNonofr
Copy link
Contributor

@CGNonofr CGNonofr commented May 2, 2025

Experimental support for shadow root, for a better css isolation between the user app and the VSCode workbench.

A few parts of VSCode (regarding focus detection mainly) needed to be patched in order to work.
It also required some change so that styles are loaded in the ShadowDom

@CGNonofr CGNonofr requested a review from kaisalmen May 2, 2025 10:31
Copy link

github-actions bot commented May 2, 2025

🎉 This PR is included in version 16.1.0-shadow-root.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@kaisalmen
Copy link
Collaborator

@CGNonofr is this ready for review or are you still implementing changes?

@CGNonofr
Copy link
Contributor Author

CGNonofr commented May 3, 2025

@CGNonofr is this ready for review or are you still implementing changes?

I think so! I didn't really have the time to deeply test it but any fix can be done later as soon as nothing is broken without shadow dom

kaisalmen
kaisalmen previously approved these changes May 5, 2025
Copy link
Collaborator

@kaisalmen kaisalmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I will test it with monaco-languageclient once it is available and provide feedback.

@CGNonofr
Copy link
Contributor Author

CGNonofr commented May 5, 2025

@kaisalmen @samuel-olivier 2 new commits:

  • fix: fix product config override:
    A bug made it so if the user is providing a productConfiguration, it was overriding ALL properties of the default product configuration, including the quality which is reset from 'stable' to 'undefined'
    A "new" feature (experimentalEditContextEnabled) is enabled by default based on it, and is still a bit bugged (unable to paste in a search field for instance)
  • fix: patch xterm to support shadow dom
    xterm webgl renderer is refusing to attach inside a shadow dom because of a wrong check. Until it's fixed and deployed in Xterm, I've added a notice and patched it in the demo (see Support shadow dom in webgl renderer xtermjs/xterm.js#5334)

Loïc Mangeonjean added 2 commits May 5, 2025 12:51
so that the quality is not undefined, so that it doesn't  try to use the `experimentalEditContextEnabled` option
Copy link
Collaborator

@kaisalmen kaisalmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes, please go ahead.

@CGNonofr CGNonofr merged commit 05b2386 into main May 5, 2025
2 checks passed
@CGNonofr CGNonofr deleted the shadow-root branch May 5, 2025 11:45
Copy link

github-actions bot commented May 5, 2025

🎉 This PR is included in version 16.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants