-
Notifications
You must be signed in to change notification settings - Fork 49
Support shadow root #617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support shadow root #617
Conversation
🎉 This PR is included in version 16.1.0-shadow-root.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
@CGNonofr is this ready for review or are you still implementing changes? |
I think so! I didn't really have the time to deeply test it but any fix can be done later as soon as nothing is broken without shadow dom |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I will test it with monaco-languageclient once it is available and provide feedback.
@kaisalmen @samuel-olivier 2 new commits:
|
so that the quality is not undefined, so that it doesn't try to use the `experimentalEditContextEnabled` option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes, please go ahead.
🎉 This PR is included in version 16.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Experimental support for shadow root, for a better css isolation between the user app and the VSCode workbench.
A few parts of VSCode (regarding focus detection mainly) needed to be patched in order to work.
It also required some change so that styles are loaded in the ShadowDom