Setup Converters Package properly for Sample App Usage #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before it meant that we couldn't work on the Converters component and see results in Sample App as it was pulling in the pre-built NuGet package With this change, we can define the property in the root props for the Windows repo (like we do with Extensions) so that it'll use the source project when running from there. Like Extensions does for the Tests.
michael-hawker
added
bug 🐛
Arlodotexe
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue introduced in #91
Before it meant that we couldn't work on the Converters component and see results in Sample App as it was pulling in the pre-built NuGet package.
With this change, we can define the property in the root props for the Windows repo (like we do with Extensions) so that it'll use the source project when running from there. Like Extensions does for the Tests.
Related to CommunityToolkit/Windows#117
DependencyVariantproperty for app heads (like was introduced for test heads) which is used to pickup the proper dependency.We could theoretically re-use the PackageIdVariant, but probably best to leave them separate as they serve different purposes/ends to different problems.
Once this is merged, we can update the Windows repo with the new property in
Directory.build.props: