Skip to content

feat: updated docs and README.md #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2024
Merged

feat: updated docs and README.md #61

merged 1 commit into from
Jul 14, 2024

Conversation

mvanwyk
Copy link
Contributor

@mvanwyk mvanwyk commented Jul 14, 2024

PR Type

Documentation, Enhancement


Description

  • Comprehensive update to the README.md file, including new project description, features, detailed examples, and additional sections for contributing, contact/support, and acknowledgements.
  • Added new documentation files for various analysis modules: Cross Shop Analysis, Customer Analysis, Gain Loss Analysis, Range Planning, Segmentation, and Standard Graphs.
  • Removed outdated Data Simulation documentation.
  • Updated MkDocs configuration (mkdocs.yml) to include new URLs and navigation links for examples and API references.
  • Enhanced stylesheet (extra.css) to adjust the font size for repository source information.

Changes walkthrough 📝

Relevant files
Documentation
8 files
README.md
Comprehensive update to README with new examples and sections.

README.md

  • Updated the project description and features.
  • Added detailed examples for various analyses.
  • Included new sections for contributing, contact/support, and
    acknowledgements.
  • Updated installation instructions and added GitHub installation
    option.
  • +157/-10
    cross_shop.md
    Added Cross Shop Analysis documentation.                                 

    docs/api/cross_shop.md

    • Added documentation for Cross Shop Analysis.
    +3/-0     
    customer.md
    Added Customer Analysis documentation.                                     

    docs/api/customer.md

    • Added documentation for Customer Analysis.
    +3/-0     
    gain_loss.md
    Added Gain Loss Analysis documentation.                                   

    docs/api/gain_loss.md

    • Added documentation for Gain Loss Analysis.
    +3/-0     
    range_planning.md
    Added Range Planning documentation.                                           

    docs/api/range_planning.md

    • Added documentation for Range Planning.
    +3/-0     
    segmentation.md
    Added Segmentation documentation.                                               

    docs/api/segmentation.md

    • Added documentation for Segmentation.
    +3/-0     
    simulation.md
    Removed Data Simulation documentation.                                     

    docs/api/simulation.md

    • Removed Data Simulation documentation.
    +0/-3     
    standard_graphs.md
    Added Standard Graphs documentation.                                         

    docs/api/standard_graphs.md

    • Added documentation for Standard Graphs.
    +3/-0     
    Enhancement
    1 files
    extra.css
    Updated stylesheet for repository source font size.           

    docs/stylesheets/extra.css

    • Adjusted font size for repository source information.
    +4/-0     
    Configuration changes
    1 files
    mkdocs.yml
    Updated MkDocs configuration with new URLs and navigation.

    mkdocs.yml

  • Updated site URL and repository information.
  • Added new navigation links for examples and API references.
  • +10/-1   

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    Summary by CodeRabbit

    • Documentation

      • Completely revamped the README to emphasize retail analytics features, added new examples, and improved structure for easier navigation.
      • Introduced new documentation files for various modules including Gain Loss Analysis, Cross Shop Analysis, Customer Retention, Range Planning, Segmentation, and Standard Graphs.
      • Updated the contributing section to encourage community contributions and added a new contact/support section.
    • Style

      • Enhanced styling for documentation with new CSS classes for better readability.
    • Chores

      • Updated mkdocs.yml with new site and repository URLs, and added new navigation items for easier reference.

    Copy link

    coderabbitai bot commented Jul 14, 2024

    Walkthrough

    The PyRetailScience project has been rebranded and updated to emphasize bespoke retail analytics. Significant changes were made to the README.md, including new examples and code snippets. The GainLoss and CrossShop classes received new parameters for enhanced functionality. New documentation files for various analytic modules were added, and the mkdocs.yml configuration was updated to reflect these changes and new navigation structure.

    Changes

    File/Path Summary
    README.md Major update to rebrand the project and include new examples and documentation links.
    pyretailscience/gain_loss Added value_col parameter to GainLoss constructor; updated plot method signature.
    pyretailscience/cross_shop Renamed module; updated CrossShop constructor and plot method with new parameters.
    docs/api/gain_loss.md New documentation for Gain Loss Analysis.
    docs/api/cross_shop.md New documentation for Cross Shop Analysis.
    docs/api/customer.md New documentation for Customer Retention Analysis.
    docs/api/range_planning.md New documentation for Range Planning.
    docs/api/segmentation.md New documentation for Segmentation.
    docs/api/standard_graphs.md New documentation for Standard Graphs.
    docs/stylesheets/extra.css Added styling for the .md-source__repository class.
    mkdocs.yml Updated site URL, added repo URL and name, and new navigation items under "Reference".

    Poem

    In the world of retail science, a change so grand,
    Bespoke analytics now taking a stand.
    With GainLoss and CrossShop, new powers in tow,
    Charts and workflows, making data glow.
    From customer tales to planning ranges wide,
    PyRetailScience, our analytical guide.
    🌟📊🐇


    Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

    Share
    Tips

    Chat

    There are 3 ways to chat with CodeRabbit:

    • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
      • I pushed a fix in commit <commit_id>.
      • Generate unit testing code for this file.
      • Open a follow-up GitHub issue for this discussion.
    • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
      • @coderabbitai generate unit testing code for this file.
      • @coderabbitai modularize this function.
    • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
      • @coderabbitai generate interesting stats about this repository and render them as a table.
      • @coderabbitai show all the console.log statements in this repository.
      • @coderabbitai read src/utils.ts and generate unit testing code.
      • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
      • @coderabbitai help me debug CodeRabbit configuration file.

    Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

    CodeRabbit Commands (invoked as PR comments)

    • @coderabbitai pause to pause the reviews on a PR.
    • @coderabbitai resume to resume the paused reviews.
    • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
    • @coderabbitai full review to do a full review from scratch and review all the files again.
    • @coderabbitai summary to regenerate the summary of the PR.
    • @coderabbitai resolve resolve all the CodeRabbit review comments.
    • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
    • @coderabbitai help to get help.

    Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

    CodeRabbit Configration File (.coderabbit.yaml)

    • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
    • Please see the configuration documentation for more information.
    • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

    Documentation and Community

    • Visit our Documentation for detailed information on how to use CodeRabbit.
    • Join our Discord Community to get help, request features, and share feedback.
    • Follow us on X/Twitter for updates and announcements.

    @qodo-merge-pro qodo-merge-pro bot added documentation Improvements or additions to documentation enhancement New feature or request Review effort [1-5]: 1 labels Jul 14, 2024
    Copy link
    Contributor

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No key issues to review

    Copy link
    Contributor

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Score
    Accessibility
    Improve accessibility and SEO with descriptive alt text for images

    Add alt text to images for better accessibility and SEO.

    README.md [1]

    -![PyRetailScience Logo](https://raw.githubusercontent.com/Data-Simply/pyretailscience/main/readme_assets/logo.png)
    +![PyRetailScience Logo - Home Page](https://raw.githubusercontent.com/Data-Simply/pyretailscience/main/readme_assets/logo.png)
     
    • Apply this suggestion
    Suggestion importance[1-10]: 9

    Why: Adding descriptive alt text to images significantly improves accessibility for visually impaired users and enhances SEO. This is a valuable improvement.

    9
    Maintainability
    Streamline installation instructions to enhance readability and user experience

    To avoid redundancy and maintain clarity, consider merging the installation
    instructions into a single section with tabs or dropdowns for different installation
    methods.

    README.md [11-21]

    -To get the latest release:
    -```bash
    -pip install pyretailscience
    -```
    -Alternatively, if you want the very latest version of the package you can install from GitHub:
    -```bash
    -pip install git+https://github.com/Data-Simply/pyretailscience.git
    -```
    +To install PyRetailScience, choose one of the following methods:
    +- **Latest Release**:
    +  ```bash
    +  pip install pyretailscience
    +  ```
    +- **From GitHub (Latest Version)**:
    +  ```bash
    +  pip install git+https://github.com/Data-Simply/pyretailscience.git
    +  ```
     
    • Apply this suggestion
    Suggestion importance[1-10]: 8

    Why: Merging the installation instructions into a single section with clear options improves readability and user experience, making it easier for users to find the relevant installation method.

    8

    Copy link

    codecov bot commented Jul 14, 2024

    Codecov Report

    All modified and coverable lines are covered by tests ✅

    Copy link

    @coderabbitai coderabbitai bot left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Actionable comments posted: 2

    Outside diff range, codebase verification and nitpick comments (1)
    README.md (1)

    Line range hint 1-189:
    Specify language for fenced code blocks.

    Add the language specification to the fenced code blocks for better syntax highlighting.

    -```
    +```python
    Tools
    Markdownlint

    107-107: null
    Fenced code blocks should have a language specified

    (MD040, fenced-code-language)

    Review details

    Configuration used: CodeRabbit UI
    Review profile: CHILL

    Commits

    Files that changed from the base of the PR and between 5bc6098 and 62ed929.

    Files selected for processing (9)
    • README.md (3 hunks)
    • docs/api/cross_shop.md (1 hunks)
    • docs/api/customer.md (1 hunks)
    • docs/api/gain_loss.md (1 hunks)
    • docs/api/range_planning.md (1 hunks)
    • docs/api/segmentation.md (1 hunks)
    • docs/api/standard_graphs.md (1 hunks)
    • docs/stylesheets/extra.css (1 hunks)
    • mkdocs.yml (2 hunks)
    Files skipped from review due to trivial changes (6)
    • docs/api/customer.md
    • docs/api/gain_loss.md
    • docs/api/range_planning.md
    • docs/api/segmentation.md
    • docs/api/standard_graphs.md
    • docs/stylesheets/extra.css
    Additional context used
    Markdownlint
    README.md

    107-107: null
    Fenced code blocks should have a language specified

    (MD040, fenced-code-language)


    159-159: null
    Bare URL used

    (MD034, no-bare-urls)


    173-173: Expected: dash; Actual: asterisk
    Unordered list style

    (MD004, ul-style)


    174-174: Expected: dash; Actual: asterisk
    Unordered list style

    (MD004, ul-style)


    175-175: Expected: dash; Actual: asterisk
    Unordered list style

    (MD004, ul-style)


    176-176: Expected: dash; Actual: asterisk
    Unordered list style

    (MD004, ul-style)


    177-177: Expected: dash; Actual: asterisk
    Unordered list style

    (MD004, ul-style)


    178-178: Expected: dash; Actual: asterisk
    Unordered list style

    (MD004, ul-style)


    179-179: Expected: dash; Actual: asterisk
    Unordered list style

    (MD004, ul-style)


    180-180: Expected: dash; Actual: asterisk
    Unordered list style

    (MD004, ul-style)


    181-181: Expected: dash; Actual: asterisk
    Unordered list style

    (MD004, ul-style)


    182-182: Expected: dash; Actual: asterisk
    Unordered list style

    (MD004, ul-style)


    183-183: Expected: dash; Actual: asterisk
    Unordered list style

    (MD004, ul-style)


    184-184: Expected: dash; Actual: asterisk
    Unordered list style

    (MD004, ul-style)


    185-185: Expected: dash; Actual: asterisk
    Unordered list style

    (MD004, ul-style)


    186-186: Expected: dash; Actual: asterisk
    Unordered list style

    (MD004, ul-style)

    LanguageTool
    README.md

    [style] ~159-~159: The phrase “a variety of” may be wordy. To make your writing clearer, consider replacing it.
    Context: ...atasimply.co. We work with companies at a variety of scales and with varying levels of data ...

    (A_VARIETY_OF)

    Additional comments not posted (3)
    docs/api/cross_shop.md (1)

    1-3: Documentation update looks good.

    The added lines introduce a section header and a reference to the pyretailscience.cross_shop module.

    mkdocs.yml (2)

    2-4: Configuration update looks good.

    The site URL, repository URL, and repository name have been updated appropriately.


    17-24: Navigation items update looks good.

    New navigation items have been added under the "Reference" section, linking to the new documentation files.

    README.md Outdated
    Comment on lines 173 to 186
    * Loblaws
    * Dominos
    * Sainbury's
    * IKI
    * Migros
    * Sephora
    * Nectar
    * Metro
    * Coles
    * GANNI
    * Mindful Chef
    * Auchan
    * Attraction Tickets Direct
    * Roman Originals
    Copy link

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Consistent unordered list style.

    Use dashes instead of asterisks for unordered list items.

    -* Loblaws
    -* Dominos
    -* Sainbury's
    -* IKI
    -* Migros
    -* Sephora
    -* Nectar
    -* Metro
    -* Coles
    -* GANNI
    -* Mindful Chef
    -* Auchan
    -* Attraction Tickets Direct
    -* Roman Originals
    + - Loblaws
    + - Dominos
    + - Sainbury's
    + - IKI
    + - Migros
    + - Sephora
    + - Nectar
    + - Metro
    + - Coles
    + - GANNI
    + - Mindful Chef
    + - Auchan
    + - Attraction Tickets Direct
    + - Roman Originals

    Committable suggestion was skipped due to low confidence.

    Tools
    Markdownlint

    173-173: Expected: dash; Actual: asterisk
    Unordered list style

    (MD004, ul-style)


    174-174: Expected: dash; Actual: asterisk
    Unordered list style

    (MD004, ul-style)


    175-175: Expected: dash; Actual: asterisk
    Unordered list style

    (MD004, ul-style)


    176-176: Expected: dash; Actual: asterisk
    Unordered list style

    (MD004, ul-style)


    177-177: Expected: dash; Actual: asterisk
    Unordered list style

    (MD004, ul-style)


    178-178: Expected: dash; Actual: asterisk
    Unordered list style

    (MD004, ul-style)


    179-179: Expected: dash; Actual: asterisk
    Unordered list style

    (MD004, ul-style)


    180-180: Expected: dash; Actual: asterisk
    Unordered list style

    (MD004, ul-style)


    181-181: Expected: dash; Actual: asterisk
    Unordered list style

    (MD004, ul-style)


    182-182: Expected: dash; Actual: asterisk
    Unordered list style

    (MD004, ul-style)


    183-183: Expected: dash; Actual: asterisk
    Unordered list style

    (MD004, ul-style)


    184-184: Expected: dash; Actual: asterisk
    Unordered list style

    (MD004, ul-style)


    185-185: Expected: dash; Actual: asterisk
    Unordered list style

    (MD004, ul-style)


    186-186: Expected: dash; Actual: asterisk
    Unordered list style

    (MD004, ul-style)


    This repository is supported by Data simply.

    If you are interested in seeing what Data Simply can do for you, then please email [email protected]. We work with companies at a variety of scales and with varying levels of data and retail analytics sophistication, to help them build, scale or streamline their analysis capabilities.
    Copy link

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Avoid using bare URLs.

    Use markdown syntax to create a clickable link.

    -If you are interested in seeing what Data Simply can do for you, then please email [email protected].
    +If you are interested in seeing what Data Simply can do for you, then please [email us](mailto:[email protected]).
    Committable suggestion

    ‼️ IMPORTANT
    Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

    Suggested change
    If you are interested in seeing what Data Simply can do for you, then please email [email protected]. We work with companies at a variety of scales and with varying levels of data and retail analytics sophistication, to help them build, scale or streamline their analysis capabilities.
    If you are interested in seeing what Data Simply can do for you, then please [email us](mailto:[email protected]). We work with companies at a variety of scales and with varying levels of data and retail analytics sophistication, to help them build, scale or streamline their analysis capabilities.
    Tools
    LanguageTool

    [style] ~159-~159: The phrase “a variety of” may be wordy. To make your writing clearer, consider replacing it.
    Context: ...atasimply.co. We work with companies at a variety of scales and with varying levels of data ...

    (A_VARIETY_OF)

    Markdownlint

    159-159: null
    Bare URL used

    (MD034, no-bare-urls)

    @mvanwyk mvanwyk force-pushed the docs_improvements branch from 62ed929 to bae1f0a Compare July 14, 2024 11:31
    Copy link

    @coderabbitai coderabbitai bot left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Actionable comments posted: 0

    Review details

    Configuration used: CodeRabbit UI
    Review profile: CHILL

    Commits

    Files that changed from the base of the PR and between 62ed929 and bae1f0a.

    Files selected for processing (9)
    • README.md (3 hunks)
    • docs/api/cross_shop.md (1 hunks)
    • docs/api/customer.md (1 hunks)
    • docs/api/gain_loss.md (1 hunks)
    • docs/api/range_planning.md (1 hunks)
    • docs/api/segmentation.md (1 hunks)
    • docs/api/standard_graphs.md (1 hunks)
    • docs/stylesheets/extra.css (1 hunks)
    • mkdocs.yml (2 hunks)
    Files skipped from review due to trivial changes (3)
    • docs/api/cross_shop.md
    • docs/api/customer.md
    • docs/api/gain_loss.md
    Files skipped from review as they are similar to previous changes (5)
    • docs/api/range_planning.md
    • docs/api/segmentation.md
    • docs/api/standard_graphs.md
    • docs/stylesheets/extra.css
    • mkdocs.yml
    Additional context used
    LanguageTool
    README.md

    [style] ~159-~159: The phrase “a variety of” may be wordy. To make your writing clearer, consider replacing it.
    Context: ...atasimply.co. We work with companies at a variety of scales and with varying levels of data ...

    (A_VARIETY_OF)

    Markdownlint
    README.md

    159-159: null
    Bare URL used

    (MD034, no-bare-urls)

    Additional comments not posted (6)
    README.md (6)

    1-7: LGTM!

    The addition of the logo and introductory lines improves the visual appeal and clarity of the README.


    11-21: LGTM!

    The installation instructions are clear and follow standard practices.


    23-35: LGTM!

    The feature descriptions are clear, and the images enhance the understanding of the features.


    37-133: LGTM!

    The examples are well-documented and provide clear guidance on how to use the library.


    159-159: Avoid using bare URLs.

    Use markdown syntax to create a clickable link.

    -If you are interested in seeing what Data Simply can do for you, then please email [email protected].
    +If you are interested in seeing what Data Simply can do for you, then please [email us](mailto:[email protected]).
    Tools
    LanguageTool

    [style] ~159-~159: The phrase “a variety of” may be wordy. To make your writing clearer, consider replacing it.
    Context: ...atasimply.co. We work with companies at a variety of scales and with varying levels of data ...

    (A_VARIETY_OF)

    Markdownlint

    159-159: null
    Bare URL used

    (MD034, no-bare-urls)


    173-186: Consistent unordered list style.

    Use dashes instead of asterisks for unordered list items.

    -* Loblaws
    -* Dominos
    -* Sainbury's
    -* IKI
    -* Migros
    -* Sephora
    -* Nectar
    -* Metro
    -* Coles
    -* GANNI
    -* Mindful Chef
    -* Auchan
    -* Attraction Tickets Direct
    -* Roman Originals
    + - Loblaws
    + - Dominos
    + - Sainbury's
    + - IKI
    + - Migros
    + - Sephora
    + - Nectar
    + - Metro
    + - Coles
    + - GANNI
    + - Mindful Chef
    + - Auchan
    + - Attraction Tickets Direct
    + - Roman Originals

    @mvanwyk mvanwyk merged commit 5a2ec15 into main Jul 14, 2024
    2 checks passed
    @mvanwyk mvanwyk deleted the docs_improvements branch July 14, 2024 11:33
    murray-ds pushed a commit that referenced this pull request Feb 2, 2025
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    documentation Improvements or additions to documentation enhancement New feature or request Review effort [1-5]: 1
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant