-
Notifications
You must be signed in to change notification settings - Fork 1
feat: updated docs and README.md #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe PyRetailScience project has been rebranded and updated to emphasize bespoke retail analytics. Significant changes were made to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
PR Reviewer Guide 🔍
|
PR Code Suggestions ✨
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
Outside diff range, codebase verification and nitpick comments (1)
README.md (1)
Line range hint
1-189
:
Specify language for fenced code blocks.Add the language specification to the fenced code blocks for better syntax highlighting.
-``` +```pythonTools
Markdownlint
107-107: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (9)
- README.md (3 hunks)
- docs/api/cross_shop.md (1 hunks)
- docs/api/customer.md (1 hunks)
- docs/api/gain_loss.md (1 hunks)
- docs/api/range_planning.md (1 hunks)
- docs/api/segmentation.md (1 hunks)
- docs/api/standard_graphs.md (1 hunks)
- docs/stylesheets/extra.css (1 hunks)
- mkdocs.yml (2 hunks)
Files skipped from review due to trivial changes (6)
- docs/api/customer.md
- docs/api/gain_loss.md
- docs/api/range_planning.md
- docs/api/segmentation.md
- docs/api/standard_graphs.md
- docs/stylesheets/extra.css
Additional context used
Markdownlint
README.md
107-107: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
159-159: null
Bare URL used(MD034, no-bare-urls)
173-173: Expected: dash; Actual: asterisk
Unordered list style(MD004, ul-style)
174-174: Expected: dash; Actual: asterisk
Unordered list style(MD004, ul-style)
175-175: Expected: dash; Actual: asterisk
Unordered list style(MD004, ul-style)
176-176: Expected: dash; Actual: asterisk
Unordered list style(MD004, ul-style)
177-177: Expected: dash; Actual: asterisk
Unordered list style(MD004, ul-style)
178-178: Expected: dash; Actual: asterisk
Unordered list style(MD004, ul-style)
179-179: Expected: dash; Actual: asterisk
Unordered list style(MD004, ul-style)
180-180: Expected: dash; Actual: asterisk
Unordered list style(MD004, ul-style)
181-181: Expected: dash; Actual: asterisk
Unordered list style(MD004, ul-style)
182-182: Expected: dash; Actual: asterisk
Unordered list style(MD004, ul-style)
183-183: Expected: dash; Actual: asterisk
Unordered list style(MD004, ul-style)
184-184: Expected: dash; Actual: asterisk
Unordered list style(MD004, ul-style)
185-185: Expected: dash; Actual: asterisk
Unordered list style(MD004, ul-style)
186-186: Expected: dash; Actual: asterisk
Unordered list style(MD004, ul-style)
LanguageTool
README.md
[style] ~159-~159: The phrase “a variety of” may be wordy. To make your writing clearer, consider replacing it.
Context: ...atasimply.co. We work with companies at a variety of scales and with varying levels of data ...(A_VARIETY_OF)
Additional comments not posted (3)
docs/api/cross_shop.md (1)
1-3
: Documentation update looks good.The added lines introduce a section header and a reference to the
pyretailscience.cross_shop
module.mkdocs.yml (2)
2-4
: Configuration update looks good.The site URL, repository URL, and repository name have been updated appropriately.
17-24
: Navigation items update looks good.New navigation items have been added under the "Reference" section, linking to the new documentation files.
README.md
Outdated
* Loblaws | ||
* Dominos | ||
* Sainbury's | ||
* IKI | ||
* Migros | ||
* Sephora | ||
* Nectar | ||
* Metro | ||
* Coles | ||
* GANNI | ||
* Mindful Chef | ||
* Auchan | ||
* Attraction Tickets Direct | ||
* Roman Originals |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consistent unordered list style.
Use dashes instead of asterisks for unordered list items.
-* Loblaws
-* Dominos
-* Sainbury's
-* IKI
-* Migros
-* Sephora
-* Nectar
-* Metro
-* Coles
-* GANNI
-* Mindful Chef
-* Auchan
-* Attraction Tickets Direct
-* Roman Originals
+ - Loblaws
+ - Dominos
+ - Sainbury's
+ - IKI
+ - Migros
+ - Sephora
+ - Nectar
+ - Metro
+ - Coles
+ - GANNI
+ - Mindful Chef
+ - Auchan
+ - Attraction Tickets Direct
+ - Roman Originals
Committable suggestion was skipped due to low confidence.
Tools
Markdownlint
173-173: Expected: dash; Actual: asterisk
Unordered list style(MD004, ul-style)
174-174: Expected: dash; Actual: asterisk
Unordered list style(MD004, ul-style)
175-175: Expected: dash; Actual: asterisk
Unordered list style(MD004, ul-style)
176-176: Expected: dash; Actual: asterisk
Unordered list style(MD004, ul-style)
177-177: Expected: dash; Actual: asterisk
Unordered list style(MD004, ul-style)
178-178: Expected: dash; Actual: asterisk
Unordered list style(MD004, ul-style)
179-179: Expected: dash; Actual: asterisk
Unordered list style(MD004, ul-style)
180-180: Expected: dash; Actual: asterisk
Unordered list style(MD004, ul-style)
181-181: Expected: dash; Actual: asterisk
Unordered list style(MD004, ul-style)
182-182: Expected: dash; Actual: asterisk
Unordered list style(MD004, ul-style)
183-183: Expected: dash; Actual: asterisk
Unordered list style(MD004, ul-style)
184-184: Expected: dash; Actual: asterisk
Unordered list style(MD004, ul-style)
185-185: Expected: dash; Actual: asterisk
Unordered list style(MD004, ul-style)
186-186: Expected: dash; Actual: asterisk
Unordered list style(MD004, ul-style)
|
||
This repository is supported by Data simply. | ||
|
||
If you are interested in seeing what Data Simply can do for you, then please email [email protected]. We work with companies at a variety of scales and with varying levels of data and retail analytics sophistication, to help them build, scale or streamline their analysis capabilities. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid using bare URLs.
Use markdown syntax to create a clickable link.
-If you are interested in seeing what Data Simply can do for you, then please email [email protected].
+If you are interested in seeing what Data Simply can do for you, then please [email us](mailto:[email protected]).
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
If you are interested in seeing what Data Simply can do for you, then please email [email protected]. We work with companies at a variety of scales and with varying levels of data and retail analytics sophistication, to help them build, scale or streamline their analysis capabilities. | |
If you are interested in seeing what Data Simply can do for you, then please [email us](mailto:[email protected]). We work with companies at a variety of scales and with varying levels of data and retail analytics sophistication, to help them build, scale or streamline their analysis capabilities. |
Tools
LanguageTool
[style] ~159-~159: The phrase “a variety of” may be wordy. To make your writing clearer, consider replacing it.
Context: ...atasimply.co. We work with companies at a variety of scales and with varying levels of data ...(A_VARIETY_OF)
Markdownlint
159-159: null
Bare URL used(MD034, no-bare-urls)
62ed929
to
bae1f0a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (9)
- README.md (3 hunks)
- docs/api/cross_shop.md (1 hunks)
- docs/api/customer.md (1 hunks)
- docs/api/gain_loss.md (1 hunks)
- docs/api/range_planning.md (1 hunks)
- docs/api/segmentation.md (1 hunks)
- docs/api/standard_graphs.md (1 hunks)
- docs/stylesheets/extra.css (1 hunks)
- mkdocs.yml (2 hunks)
Files skipped from review due to trivial changes (3)
- docs/api/cross_shop.md
- docs/api/customer.md
- docs/api/gain_loss.md
Files skipped from review as they are similar to previous changes (5)
- docs/api/range_planning.md
- docs/api/segmentation.md
- docs/api/standard_graphs.md
- docs/stylesheets/extra.css
- mkdocs.yml
Additional context used
LanguageTool
README.md
[style] ~159-~159: The phrase “a variety of” may be wordy. To make your writing clearer, consider replacing it.
Context: ...atasimply.co. We work with companies at a variety of scales and with varying levels of data ...(A_VARIETY_OF)
Markdownlint
README.md
159-159: null
Bare URL used(MD034, no-bare-urls)
Additional comments not posted (6)
README.md (6)
1-7
: LGTM!The addition of the logo and introductory lines improves the visual appeal and clarity of the README.
11-21
: LGTM!The installation instructions are clear and follow standard practices.
23-35
: LGTM!The feature descriptions are clear, and the images enhance the understanding of the features.
37-133
: LGTM!The examples are well-documented and provide clear guidance on how to use the library.
159-159
: Avoid using bare URLs.Use markdown syntax to create a clickable link.
-If you are interested in seeing what Data Simply can do for you, then please email [email protected]. +If you are interested in seeing what Data Simply can do for you, then please [email us](mailto:[email protected]).Tools
LanguageTool
[style] ~159-~159: The phrase “a variety of” may be wordy. To make your writing clearer, consider replacing it.
Context: ...atasimply.co. We work with companies at a variety of scales and with varying levels of data ...(A_VARIETY_OF)
Markdownlint
159-159: null
Bare URL used(MD034, no-bare-urls)
173-186
: Consistent unordered list style.Use dashes instead of asterisks for unordered list items.
-* Loblaws -* Dominos -* Sainbury's -* IKI -* Migros -* Sephora -* Nectar -* Metro -* Coles -* GANNI -* Mindful Chef -* Auchan -* Attraction Tickets Direct -* Roman Originals + - Loblaws + - Dominos + - Sainbury's + - IKI + - Migros + - Sephora + - Nectar + - Metro + - Coles + - GANNI + - Mindful Chef + - Auchan + - Attraction Tickets Direct + - Roman Originals
PR Type
Documentation, Enhancement
Description
README.md
file, including new project description, features, detailed examples, and additional sections for contributing, contact/support, and acknowledgements.mkdocs.yml
) to include new URLs and navigation links for examples and API references.extra.css
) to adjust the font size for repository source information.Changes walkthrough 📝
8 files
README.md
Comprehensive update to README with new examples and sections.
README.md
acknowledgements.
option.
cross_shop.md
Added Cross Shop Analysis documentation.
docs/api/cross_shop.md
customer.md
Added Customer Analysis documentation.
docs/api/customer.md
gain_loss.md
Added Gain Loss Analysis documentation.
docs/api/gain_loss.md
range_planning.md
Added Range Planning documentation.
docs/api/range_planning.md
segmentation.md
Added Segmentation documentation.
docs/api/segmentation.md
simulation.md
Removed Data Simulation documentation.
docs/api/simulation.md
standard_graphs.md
Added Standard Graphs documentation.
docs/api/standard_graphs.md
1 files
extra.css
Updated stylesheet for repository source font size.
docs/stylesheets/extra.css
1 files
mkdocs.yml
Updated MkDocs configuration with new URLs and navigation.
mkdocs.yml
Summary by CodeRabbit
Documentation
Style
Chores
mkdocs.yml
with new site and repository URLs, and added new navigation items for easier reference.