Skip to content

RUM-9522 Migrate Crash messages to payload format #2279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 9, 2025
Merged

RUM-9522 Migrate Crash messages to payload format #2279

merged 2 commits into from
May 9, 2025

Conversation

maxep
Copy link
Member

@maxep maxep commented Apr 30, 2025 •
edited
Loading

What and why?

Following #2276

Migrate Crash messages on the message-bus to the new strongly-typed .payload

How?

  • Create a shared Crash type.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes
  • Add Objective-C interface for public APIs (see our guidelines (internal) and run make api-surface)

@maxep maxep requested review from a team as code owners April 30, 2025 12:43
@maxep maxep force-pushed the maxep/RUM-9522/migrate-crash-messages branch from 5fc1de1 to 79f340b Compare April 30, 2025 13:00
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Apr 30, 2025 •
edited
Loading

Datadog Report

Branch report: maxep/RUM-9522/migrate-crash-messages
Commit report: ebc982b
Test service: dd-sdk-ios

✅ 0 Failed, 900 Passed, 2996 Skipped, 3m 47.06s Total duration (52.44s time saved)

@maxep maxep force-pushed the maxep/RUM-9522/migrate-logs-messages branch from 6be10fd to ebd11b0 Compare May 5, 2025 13:59
@maxep maxep force-pushed the maxep/RUM-9522/migrate-crash-messages branch from 79f340b to f4224d8 Compare May 6, 2025 14:00
simaoseica-dd
simaoseica-dd previously approved these changes May 6, 2025
View reviewed changes
Copy link
Contributor

@simaoseica-dd simaoseica-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I will look again after your rebase on the other commits

@maxep maxep force-pushed the maxep/RUM-9522/migrate-logs-messages branch from f615a0a to d1c172e Compare May 6, 2025 16:10
Base automatically changed from maxep/RUM-9522/migrate-logs-messages to develop May 7, 2025 12:14
@dd-mergequeue dd-mergequeue bot dismissed simaoseica-dd’s stale review May 7, 2025 12:14

The base branch was changed.

@maxep maxep changed the title RUM-9522 Migrate Crash messages to dispatch format RUM-9522 Migrate Crash messages to payload format May 7, 2025
@maxep maxep force-pushed the maxep/RUM-9522/migrate-crash-messages branch 2 times, most recently from 27ed9c4 to 178537a Compare May 7, 2025 14:12
@maxep maxep requested a review from simaoseica-dd May 7, 2025 15:38
simaoseica-dd
simaoseica-dd previously approved these changes May 7, 2025
View reviewed changes
Copy link
Contributor

@simaoseica-dd simaoseica-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@maxep maxep force-pushed the maxep/RUM-9522/migrate-crash-messages branch from 178537a to 81d06f3 Compare May 7, 2025 17:53
@maxep maxep force-pushed the maxep/RUM-9522/migrate-crash-messages branch from 81d06f3 to ebc982b Compare May 7, 2025 17:55
@maxep
Copy link
Member Author

maxep commented May 9, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented May 9, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-05-09 12:17:37 UTC ℹ️ Start processing command /merge

2025-05-09 12:17:41 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in develop is approximately 1h (p90).

2025-05-09 12:55:12 UTC ❌ MergeQueue: The checks failed on this merge request

Tests failed on this commit 15a7c7f:

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
  • Any question, go check the FAQ.

@maxep
Copy link
Member Author

maxep commented May 9, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented May 9, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-05-09 12:57:12 UTC ℹ️ Start processing command /merge

2025-05-09 12:57:18 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in develop is approximately 1h (p90).

2025-05-09 14:19:36 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 2cf5e4d into develop May 9, 2025
15 checks passed
@dd-mergequeue dd-mergequeue bot deleted the maxep/RUM-9522/migrate-crash-messages branch May 9, 2025 14:19
@maxep maxep mentioned this pull request May 12, 2025
Merged
4 tasks
@maxep maxep mentioned this pull request May 20, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariedm mariedm mariedm approved these changes

@simaoseica-dd simaoseica-dd simaoseica-dd approved these changes

Assignees
No one assigned
Labels
mergequeue-status: done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxep @mariedm @simaoseica-dd