Skip to content

RUM-9522 Remove .baggage message type from the bus #2297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 19, 2025
Merged

RUM-9522 Remove .baggage message type from the bus #2297

merged 2 commits into from
May 19, 2025

Conversation

maxep
Copy link
Member

@maxep maxep commented May 12, 2025 •
edited
Loading

What and why?

Remove .baggage message type following migration of:

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes
  • Add Objective-C interface for public APIs (see our guidelines (internal) and run make api-surface)

@maxep maxep requested review from a team as code owners May 12, 2025 12:12
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented May 12, 2025 •
edited
Loading

Datadog Report

Branch report: maxep/RUM-9522/remove-baggage-message
Commit report: 7d88b2d
Test service: dd-sdk-ios

✅ 0 Failed, 8 Passed, 3890 Skipped, 1m 46.93s Total duration (2m 39.05s time saved)

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented May 12, 2025 •
edited
Loading

Datadog Summary

✅ Code Quality    ✅ Code Security    ✅ Dependencies

Test Optimization Report

Branch report: maxep/RUM-9522/remove-baggage-message
Commit report: 6fd8e3e
Test service: dd-sdk-ios

✅ 0 Failed, 1242 Passed, 2656 Skipped, 2m 33.24s Total Time

Was this helpful? Give us feedback!

@maxep maxep force-pushed the maxep/RUM-9522/remove-baggage-message branch from 29e9284 to c5faf2b Compare May 12, 2025 15:20
@maxep maxep force-pushed the maxep/RUM-9522/remove-baggage-message branch from c5faf2b to 6fd8e3e Compare May 13, 2025 07:35
simaoseica-dd
simaoseica-dd previously approved these changes May 14, 2025
View reviewed changes
Copy link
Contributor

@simaoseica-dd simaoseica-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

ncreated
ncreated previously approved these changes May 15, 2025
View reviewed changes
Copy link
Member

@ncreated ncreated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup 🧽 💪

@maxep maxep dismissed stale reviews from ncreated and simaoseica-dd via 7d88b2d May 15, 2025 07:26
@maxep
Copy link
Member Author

maxep commented May 19, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented May 19, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-05-19 11:01:15 UTC ℹ️ Start processing command /merge

2025-05-19 11:01:20 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in develop is approximately 1h (p90).

2025-05-19 11:48:02 UTC ❌ MergeQueue: The checks failed on this merge request

Tests failed on this commit 7782312:

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
  • Any question, go check the FAQ.

@maxep
Copy link
Member Author

maxep commented May 19, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented May 19, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-05-19 11:55:03 UTC ℹ️ Start processing command /merge

2025-05-19 11:55:10 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in develop is approximately 1h (p90).

2025-05-19 12:43:52 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit f650639 into develop May 19, 2025
15 checks passed
@dd-mergequeue dd-mergequeue bot deleted the maxep/RUM-9522/remove-baggage-message branch May 19, 2025 12:43
@maxep maxep mentioned this pull request May 20, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncreated ncreated ncreated approved these changes

@simaoseica-dd simaoseica-dd simaoseica-dd left review comments

Assignees
No one assigned
Labels
mergequeue-status: done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxep @ncreated @simaoseica-dd