Skip to content

RUM-9747 Add strongly-typed additional context to core #2289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 12, 2025
Merged

RUM-9747 Add strongly-typed additional context to core #2289

merged 2 commits into from
May 12, 2025

Conversation

maxep
Copy link
Member

@maxep maxep commented May 7, 2025 •
edited
Loading

What and why?

FeatureBaggage comes with perf implications, we are replacing loosely-typed baggages in core context by strongly-typed additional context.

How?

Similar to BaggageSharing (now deprecated), add AdditionalContextSharing for sharing additional context from core and feature-scope.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes
  • Add Objective-C interface for public APIs (see our guidelines (internal) and run make api-surface)

@maxep maxep requested review from a team as code owners May 7, 2025 15:50
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented May 7, 2025 •
edited
Loading

Datadog Report

Branch report: maxep/RUM-9747/migrate-baggage-to-additional-context
Commit report: 77208b0
Test service: dd-sdk-ios

✅ 0 Failed, 1905 Passed, 1997 Skipped, 2m 34.22s Total duration (2m 5.78s time saved)

@maxep maxep mentioned this pull request May 7, 2025
Merged
4 tasks
@maxep maxep force-pushed the maxep/RUM-9747/migrate-baggage-to-additional-context branch from a016ab0 to cabcd8e Compare May 9, 2025 10:16
@maxep maxep force-pushed the maxep/RUM-9747/migrate-baggage-to-additional-context branch from cabcd8e to 77208b0 Compare May 9, 2025 10:34
simaoseica-dd
simaoseica-dd approved these changes May 9, 2025
View reviewed changes
Copy link
Contributor

@simaoseica-dd simaoseica-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done 👌

This was referenced May 9, 2025
Merged
Merged
Merged
@maxep
Copy link
Member Author

maxep commented May 12, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented May 12, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-05-12 11:45:11 UTC ℹ️ Start processing command /merge

2025-05-12 11:45:14 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in develop is approximately 1h (p90).

2025-05-12 12:31:54 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 923de8d into develop May 12, 2025
15 checks passed
@dd-mergequeue dd-mergequeue bot deleted the maxep/RUM-9747/migrate-baggage-to-additional-context branch May 12, 2025 12:31
@maxep maxep mentioned this pull request May 20, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simaoseica-dd simaoseica-dd simaoseica-dd approved these changes

Assignees
No one assigned
Labels
mergequeue-status: done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxep @simaoseica-dd