RUM-9747 Strongly-typed Trace Additional Context #2293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datadog ReportBranch report: ✅ 0 Failed, 708 Passed, 3186 Skipped, 2m 13.95s Total duration (2m 23.1s time saved) |
maxep
force-pushed
the
maxep/RUM-9747/rum-addtional-context
branch
from
9a71de0 to
eb6381b
Compare
maxep
force-pushed
the
maxep/RUM-9747/trace-additional-context
branch
from
4d4de31 to
e53d667
Compare
maxep
force-pushed
the
maxep/RUM-9747/trace-additional-context
branch
from
e53d667 to
8b6640f
Compare
maxep
force-pushed
the
maxep/RUM-9747/trace-additional-context
branch
from
8b6640f to
71b9fcf
Compare
maxep
force-pushed
the
maxep/RUM-9747/trace-additional-context
branch
from
71b9fcf to
48a1427
Compare
simaoseica-dd
approved these changes
May 19, 2025
ncreated
approved these changes
May 19, 2025
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
dd-devflow
bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
dd-devflow
bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Following: #2289
FeatureBaggagecomes with perf implications, we are replacing loosely-typed baggages in core context by strongly-typed additional context.How?
Replace Trace baggage by
SpanCoreContextas additional context.Bonus
Also fix a left-over from #2277 and replace the Trace baggage message to logs by a
.payload(TraceLogMessage).Review checklist
make api-surface)