Set container.source:ios for Session Replay webview events #2365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR by Bits for chat 3c8a1a71-2a6d-4120-b29f-b8759ff28ec3.
You can ask for changes by mentioning @DataDog in a comment.
Feedback (especially what can be better) welcome in #code-gen-feedback!
What and why?
Session Replay webview events from the Datadog browser SDK were missing the
container.source:iosfield, causing inconsistency with RUM events. This PR adds the required field to ensure proper event attribution and consistency across the SDK.How?
Modified
WebViewRecordReceiverto injectcontainer.source:iosinto each webview event before creating theWebRecord. Added comprehensive tests to verify the field is properly set on all webview replay events.Review checklist
make api-surface)