fix workspace discovery & sorting when folder has an extension#121
Merged
jplatte merged 1 commit intoDevinR528:mainfrom Jan 12, 2026
Merged
fix workspace discovery & sorting when folder has an extension#121jplatte merged 1 commit intoDevinR528:mainfrom
jplatte merged 1 commit intoDevinR528:mainfrom
Conversation
jplatte
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to add
cargo sortto docs.rs, I stumbled onto an odd issue:cargo sort --workspacejust gave me an error:Looking through the source, the culprit seems to be that we're checking for an extension instead of checking if it's a directory before adding a
Cargo.tomlsuffix / filename?Manual testing is good after this change here.
Are there unittest for this I just didn't see?
Should we add some?