Skip to content

format arrays in inline tables, optionally sort dependency feature lists#122

Merged
jplatte merged 2 commits intoDevinR528:mainfrom
syphar:sort-feature-list
Feb 27, 2026
Merged

format arrays in inline tables, optionally sort dependency feature lists#122
jplatte merged 2 commits intoDevinR528:mainfrom
syphar:sort-feature-list

Conversation

@syphar
Copy link
Copy Markdown
Contributor

@syphar syphar commented Jan 11, 2026

@syphar syphar force-pushed the sort-feature-list branch from a61cb93 to 4c01d17 Compare January 12, 2026 03:44
@syphar
Copy link
Copy Markdown
Contributor Author

syphar commented Jan 12, 2026

is there a way to get quicker feedback on any issues with CI?

right now I have to try a fix, and then wait for approval of the CI run, and then again try ?

( I don't own a windows machine)

@jplatte
Copy link
Copy Markdown
Collaborator

jplatte commented Jan 12, 2026

If there is any small refactor you can extract into a separate PR, I can merge it ahead of this one. Once you have a PR merged, I no longer need to approve CI runs 😅

Unfortunately I can't access repo settings do loosen rhe approval-required setting.

Comment thread src/fmt.rs
@syphar
Copy link
Copy Markdown
Contributor Author

syphar commented Jan 12, 2026

If there is any small refactor you can extract into a separate PR, I can merge it ahead of this one. Once you have a PR merged, I no longer need to approve CI runs 😅

perhaps #121 ?

Unfortunately I can't access repo settings do loosen rhe approval-required setting.

😅

@jplatte
Copy link
Copy Markdown
Collaborator

jplatte commented Jan 12, 2026

Oh yeah, merged!

@syphar syphar force-pushed the sort-feature-list branch from 4c01d17 to ea628c7 Compare January 12, 2026 10:54
@syphar
Copy link
Copy Markdown
Contributor Author

syphar commented Jan 12, 2026

Oh yeah, merged!

perfect, CI works now directly.

I'll ping you when CI is fixed.

@syphar syphar force-pushed the sort-feature-list branch 3 times, most recently from 35feeb9 to f2a07ee Compare January 12, 2026 17:28
Comment thread .gitattributes Outdated

*win.toml text eol=crlf No newline at end of file
*win.toml text eol=crlf
examp/features.toml text eol=lf
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a quickfix to make the tests pass.

I don't know much about git and its behaviour around line endings on windows, and also didn't fully understand the formatting code around line-endings.

With most other combinations I tried, the output was always LF, even on windows, no matter if I did set clrf: Some(true). Super odd.

Do you have a hint? or is this expected and I misunderstood the intended behaviour?

@syphar syphar requested a review from jplatte January 12, 2026 17:32
@syphar
Copy link
Copy Markdown
Contributor Author

syphar commented Jan 22, 2026

@jplatte anything missing here to make progress?

I'm happy to add whatever is needed.

Thanks!

( I'm aware this is really only a nice-to-have thing ;) )

@jplatte
Copy link
Copy Markdown
Collaborator

jplatte commented Feb 26, 2026

I want to look into the weird windows line ending issue but am very low on time. cc @thomaseizinger in case he can help out.

@syphar
Copy link
Copy Markdown
Contributor Author

syphar commented Feb 27, 2026

@jplatte I think I found the issue, it seems like i should have used the assert_eq test helper.

@jplatte
Copy link
Copy Markdown
Collaborator

jplatte commented Feb 27, 2026

Hm, I wonder why we need that helper in some tests but not others. Anyways, not related to this PR.

@jplatte jplatte merged commit e6a1727 into DevinR528:main Feb 27, 2026
4 checks passed
@syphar syphar deleted the sort-feature-list branch February 27, 2026 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature list is not formatted Feature request: sort features

2 participants