format arrays in inline tables, optionally sort dependency feature lists#122
format arrays in inline tables, optionally sort dependency feature lists#122jplatte merged 2 commits intoDevinR528:mainfrom
Conversation
a61cb93 to
4c01d17
Compare
|
is there a way to get quicker feedback on any issues with CI? right now I have to try a fix, and then wait for approval of the CI run, and then again try ? ( I don't own a windows machine) |
|
If there is any small refactor you can extract into a separate PR, I can merge it ahead of this one. Once you have a PR merged, I no longer need to approve CI runs 😅 Unfortunately I can't access repo settings do loosen rhe approval-required setting. |
perhaps #121 ?
😅 |
|
Oh yeah, merged! |
4c01d17 to
ea628c7
Compare
perfect, CI works now directly. I'll ping you when CI is fixed. |
35feeb9 to
f2a07ee
Compare
|
|
||
| *win.toml text eol=crlf No newline at end of file | ||
| *win.toml text eol=crlf | ||
| examp/features.toml text eol=lf |
There was a problem hiding this comment.
This is a quickfix to make the tests pass.
I don't know much about git and its behaviour around line endings on windows, and also didn't fully understand the formatting code around line-endings.
With most other combinations I tried, the output was always LF, even on windows, no matter if I did set clrf: Some(true). Super odd.
Do you have a hint? or is this expected and I misunderstood the intended behaviour?
|
@jplatte anything missing here to make progress? I'm happy to add whatever is needed. Thanks! ( I'm aware this is really only a nice-to-have thing ;) ) |
|
I want to look into the weird windows line ending issue but am very low on time. cc @thomaseizinger in case he can help out. |
f2a07ee to
b1ef570
Compare
|
@jplatte I think I found the issue, it seems like i should have used the |
|
Hm, I wonder why we need that helper in some tests but not others. Anyways, not related to this PR. |
resolves #89, resolves #36
related