Skip to content

Demo Pull Request #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: demo-base
Choose a base branch
from
Open

Demo Pull Request #4

wants to merge 4 commits into from

Conversation

owen-connor
Copy link

No description provided.

Copy link

gitnotebooks bot commented Nov 22, 2024

Found 2 changed notebooks. Review the changes at https://app.gitnotebooks.com/GitNotebooks/demo/pull/4

@DiffEnder DiffEnder deleted a comment from gitnotebooks-staging bot Nov 22, 2024
Copy link
Member

@smith-kyle smith-kyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

smith-kyle

This comment was marked as resolved.

smith-kyle

This comment was marked as resolved.

smith-kyle

This comment was marked as resolved.

smith-kyle

This comment was marked as resolved.

Copy link
Member

@smith-kyle smith-kyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi i am comment

Copy link
Member

@smith-kyle smith-kyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment

raise ValueError("Division by zero is not allowed")


def modulus(a, b):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey don't do this

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the essential pieces of NumPy is the ability to perform quick element-wise operations, both with basic arithmetic (addition, subtraction, multiplication, etc.) and with more sophisticated operations (trigonometric functions, exponential and logarithmic functions, etc.).

test comment

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my reply in github

Copy link
Member

@smith-kyle smith-kyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done-zo

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the essential pieces of NumPy is the ability to perform quick element-wise operations, both with basic arithmetic (addition, subtraction, multiplication, etc.) and with more sophisticated operations (trigonometric functions, exponential and logarithmic functions, etc.).

new review comment

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my gh reply

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

        raise ValueError("Division by zero is not allowed")


def modulus(a, b):

how

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# Operating on Data in Pandas

Hey @owen-connor I'm going to ping you for a demo

Copy link
Member

@smith-kyle smith-kyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My review is done

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copied from [https://github.com/jakevdp/PythonDataScienceHandbook](https://github.com/jakevdp/PythonDataScienceHandbook) with modifications to demonstrate notebook diffing.

here's my review comment

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fill = A.stack().sum()
A.add(B, fill_value=fill)

Looks good

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

    return a * b


def divide(a, b):
    if b != 0:
        return a / b
    else:
        raise ValueError("Division by zero is not allowed")

another comment

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A = pd.DataFrame(rng.randint(0, 20, (2, 2)),
                 columns=list('AB'))
B = pd.DataFrame(rng.randint(0, 10, (3, 3)),

test

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"A = rng.randint(10, size=(4, 4))\n",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants