Fix antialias issue on Android 7.0 #411
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mu29
changed the title
|
I thought this issue was being fixed in React Native core, any idea what happened? |
|
If you use default |
|
@DylanVann I'm sure that @mu29 comments are reasonable. As mentioned, I don't think this is a problem with React Native Core. Please review this issue one more time. |
|
To maintain compatibility with iOS we need to be able to round corners with different radii:
This is from the example app in |
|
I can't see issues with current corners on recent android/lib versions:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pick antialias related commit from #379 and support array type style.
Check the screenshot below. (left: original, right: modified)
or you can see #159 on your comment, Images on Android aren't antialiased well.