Round the corners manually on Nougat [Android] #491
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #491 +/- ##
=======================================
Coverage 94.73% 94.73%
=======================================
Files 1 1
Lines 19 19
=======================================
Hits 18 18
Misses 1 1Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #491 +/- ##
=======================================
Coverage 94.73% 94.73%
=======================================
Files 1 1
Lines 19 19
=======================================
Hits 18 18
Misses 1 1Continue to review full report at Codecov.
|
|
I can't see issues with current corners on recent android/lib versions:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix has been done in other forks. Just performed the same fix and made it Nougat specific with the latest master
Edit: Improved the fix by allowing override of width and height on the resulting image so that the border radius ratio is correct. This does unfortunately have the effect of potentially losing image quality since you lose the benefits of downscaling