Skip to content

Add a guard around mpu_wrappers.c #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 5, 2022
Merged

Conversation

aggarg
Copy link
Member

@aggarg aggarg commented Apr 4, 2022

Description

This prevents linker errors when this file is accidentally compiled in projects using non-MPU ports.

Test Steps

Tested compiling a both and MPU and non-MPU project.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

aggarg added 2 commits April 4, 2022 15:46
This avoid linker errors when this file is accidently compiled in
projects using non-MPU ports.

Signed-off-by: Gaurav Aggarwal <[email protected]>
Signed-off-by: Gaurav Aggarwal <[email protected]>
@aggarg aggarg requested a review from a team as a code owner April 4, 2022 10:27
@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #480 (a258e40) into main (356fff8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #480   +/-   ##
=======================================
  Coverage   92.44%   92.44%           
=======================================
  Files           4        4           
  Lines        1270     1270           
  Branches      343      343           
=======================================
  Hits         1174     1174           
  Misses         50       50           
  Partials       46       46           
Flag Coverage Δ
unittests 92.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 356fff8...a258e40. Read the comment docs.

@aggarg aggarg merged commit b5b1ff0 into FreeRTOS:main Apr 5, 2022
@aggarg aggarg deleted the mpu_wrappers branch April 6, 2022 04:53
pierrenoel-bouteville-act pushed a commit to All-Circuits-Technologies/FreeRTOS-Kernel that referenced this pull request Apr 6, 2022
…-branches

* remotes/upstream/main:
  Add a guard around mpu_wrappers.c (FreeRTOS#480)
pierrenoel-bouteville-act pushed a commit to All-Circuits-Technologies/FreeRTOS-Kernel that referenced this pull request Apr 7, 2022
* remotes/upstream/main:
  tasks.c:2067:11: warning: this condition has identical branches [-Wduplicated-branches] (FreeRTOS#482)
  Add a guard around mpu_wrappers.c (FreeRTOS#480)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants