tasks.c:2067:11: warning: this condition has identical branches [-Wduplicated-branches] #482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 5, 2022 15:33
…ing/error with option GCC -Wduplicated-branches
aggarg
reviewed
Apr 6, 2022
tasks.c
Outdated
Comment on lines
2068
to
2072
| /* if just above call of xPortStartScheduler not return pdFALSE | ||
| * Should not reach here as if the scheduler is running the | ||
| * function will not return. | ||
| * otherwise | ||
| * Should only reach here if a task calls xTaskEndScheduler(). */ |
There was a problem hiding this comment.
Suggested change
| /* if just above call of xPortStartScheduler not return pdFALSE | |
| * Should not reach here as if the scheduler is running the | |
| * function will not return. | |
| * otherwise | |
| * Should only reach here if a task calls xTaskEndScheduler(). */ | |
| /* In most cases, xPortStartScheduler() will not return. If it | |
| * returns pdTRUE then there was not enough heap memory available | |
| * to create either the Idle or the Timer task. If it returned | |
| * pdFALSE, then the application called xTaskEndScheduler(). | |
| * Most ports don't implement xTaskEndScheduler() as there is | |
| * nothing to return to. */ | |
There was a problem hiding this comment.
Done
Codecov Report
@@ Coverage Diff @@
## main #482 +/- ##
=======================================
Coverage 92.44% 92.44%
=======================================
Files 4 4
Lines 1270 1270
Branches 343 343
=======================================
Hits 1174 1174
Misses 50 50
Partials 46 46
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
…-branches * remotes/upstream/main: Add a guard around mpu_wrappers.c (FreeRTOS#480)
|
Sorry But it don't understand why formatting failed ? |
|
Please apply the following patch - formatting.zip |
aggarg
approved these changes
Apr 6, 2022
archigup
approved these changes
Apr 6, 2022
pierrenoel-bouteville-act
pushed a commit
to All-Circuits-Technologies/FreeRTOS-Kernel
that referenced
this pull request
Apr 7, 2022
* remotes/upstream/main: tasks.c:2067:11: warning: this condition has identical branches [-Wduplicated-branches] (FreeRTOS#482) Add a guard around mpu_wrappers.c (FreeRTOS#480)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace duplicated if branch because empty by a comment to avoid warning/error with option GCC -Wduplicated-branches
Test Steps
Build file with -Wduplicated-branches and -Werror with GCC
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.