Skip to content

tasks.c:2067:11: warning: this condition has identical branches [-Wduplicated-branches] #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 6, 2022
Merged

tasks.c:2067:11: warning: this condition has identical branches [-Wduplicated-branches] #482

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0dbcfc7
replace duplicated if branch because empty by a comment to avoid warn…
Apr 5, 2022
6e6c6fb
Missing ';'
Apr 5, 2022
7066ccc
cosmetic comment
Apr 5, 2022
0337c7f
update comment as suggested by Gaurav-Aggarwal-AWS
Apr 6, 2022
9204db8
Merge remote-tracking branch 'remotes/upstream/main' into Wduplicated…
Apr 6, 2022
f0fe0c3
cosmetic
Apr 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions tasks.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2064,15 +2064,14 @@ void vTaskStartScheduler( void )

/* Setting up the timer tick is hardware specific and thus in the
* portable interface. */
if( xPortStartScheduler() != pdFALSE )
{
/* Should not reach here as if the scheduler is running the
* function will not return. */
}
else
{
/* Should only reach here if a task calls xTaskEndScheduler(). */
}
xPortStartScheduler();

/* In most cases, xPortStartScheduler() will not return. If it
* returns pdTRUE then there was not enough heap memory available
* to create either the Idle or the Timer task. If it returned
* pdFALSE, then the application called xTaskEndScheduler().
* Most ports don't implement xTaskEndScheduler() as there is
* nothing to return to. */
}
else
{
Expand Down