Skip to content

Add ability, in Scenarios tests, to allow for testing array slices in the k direction #3192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pchakraborty merged 3 commits into from
Nov 22, 2024
Merged

Add ability, in Scenarios tests, to allow for testing array slices in the k direction #3192

pchakraborty merged 3 commits into from
Nov 22, 2024

Conversation

@pchakraborty
Copy link
Contributor

@pchakraborty pchakraborty commented Nov 21, 2024 •
edited
Loading

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

Implement #3187
Scenarios testing - added ability to allow for testing array slices in expectations.yaml. We can now add tests like

I: {status: complete, typekind: R4, rank: 3, k_values: [40., 20., 10.]}

Related Issue

@pchakraborty pchakraborty self-assigned this Nov 21, 2024
@pchakraborty pchakraborty changed the title Implement #3187 Add ability to allow for testing array slices in the k direction Nov 21, 2024
@pchakraborty pchakraborty added 🎁 New Feature This is a new feature 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 📈 MAPL3 MAPL 3 Related labels Nov 21, 2024
@pchakraborty pchakraborty changed the title Add ability to allow for testing array slices in the k direction Add ability, in Scenarios tests, to allow for testing array slices in the k direction Nov 21, 2024
@pchakraborty pchakraborty marked this pull request as ready for review November 21, 2024 18:54
@pchakraborty pchakraborty requested a review from a team as a code owner November 21, 2024 18:54
@pchakraborty pchakraborty mentioned this pull request Nov 21, 2024
Closed
tclune
tclune reviewed Nov 21, 2024
View reviewed changes
@pchakraborty pchakraborty merged commit 581cc45 into release/MAPL-v3 Nov 22, 2024
52 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tclune tclune tclune approved these changes

Assignees

@pchakraborty pchakraborty

Labels

0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 📈 MAPL3 MAPL 3 Related 🎁 New Feature This is a new feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pchakraborty @tclune