Skip to content

[Improvement] Validate GitVersion.Commandline and GitVersion.Portable artifacts #2255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
arturcic opened this issue May 5, 2020 · 5 comments · Fixed by #2264
Closed

[Improvement] Validate GitVersion.Commandline and GitVersion.Portable artifacts #2255

arturcic opened this issue May 5, 2020 · 5 comments · Fixed by #2264
Assignees
@arturcic
Labels
build
Milestone
5.3.3

Comments

@arturcic
Copy link
Member

arturcic commented May 5, 2020

Validate GitVersion.Commandline and GitVersion.Portable artifacts during Artifacts test stage to avoid having empty packages
@arturcic arturcic added the build label May 5, 2020
@arturcic arturcic self-assigned this May 5, 2020
@arturcic arturcic added this to the 5.3.x milestone May 5, 2020
@gep13
Copy link
Member

gep13 commented May 5, 2020

@arturcic I am curious as to what the plan is here. Is this something that you are planning on adding to the Cake script?

@arturcic arturcic changed the title [Improvement] [Improvement] Validate GitVersion.Commandline and GitVersion.Portable artifacts May 5, 2020
@arturcic
Copy link
Member Author

arturcic commented May 5, 2020

Currently we have a 'test artifacts' stage where we test the msbuild task (on Windows with msbuild, in Linux with dotnet build). We also test the dotnet global tool, and the native executables. We need to test the remaining 2 artifacts - command line and chocolatey. The way I see it is to run 2 additional jobs in this stage on Windows and execute the newly built artifacts

@arturcic
Copy link
Member Author

arturcic commented May 5, 2020

This will require both cake and yaml file to be adjusted

@gep13
Copy link
Member

gep13 commented May 5, 2020

@arturcic thanks for that. Will keep an eye on this, as I am curious to see how this will be done 😄

arturcic added a commit to arturcic/GitVersion that referenced this issue May 9, 2020
@arturcic
GitToolsGH-2255 - implemented Commandline and Portable validation
e2806b9
@arturcic arturcic mentioned this issue May 9, 2020
Merged
arturcic added a commit to arturcic/GitVersion that referenced this issue May 9, 2020
@arturcic
GitToolsGH-2255 - implemented Commandline and Portable validation
07eeee8
arturcic added a commit to arturcic/GitVersion that referenced this issue May 10, 2020
@arturcic
GitToolsGH-2255 - implemented Commandline and Portable validation
1f325d2
arturcic added a commit that referenced this issue May 10, 2020
@arturcic
GH-2255 - implemented Commandline and Portable validation
b4739a4
@arturcic arturcic modified the milestones: 5.3.x, 5.3.3 May 12, 2020
@github-actions
Copy link

🎉 This issue has been resolved in version 5.3.3 🎉
The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arturcic arturcic

Labels
build
Projects
None yet
Milestone
5.3.3
Development

Successfully merging a pull request may close this issue.

GH-2255 - implemented Commandline and Portable validation arturcic/GitVersion
2 participants
@gep13 @arturcic