Skip to content

GH-2255 - implemented Commandline and Portable validation #2264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2020

Conversation

arturcic
Copy link
Member

@arturcic arturcic commented May 9, 2020

Resolves #2255

@arturcic arturcic requested a review from gep13 May 9, 2020 20:11
@arturcic arturcic marked this pull request as draft May 9, 2020 20:14
@arturcic arturcic force-pushed the feature/validate-artifacts branch from 8d62254 to 07eeee8 Compare May 9, 2020 20:30
@arturcic arturcic force-pushed the feature/validate-artifacts branch from 07eeee8 to 1f325d2 Compare May 10, 2020 07:04
@arturcic arturcic marked this pull request as ready for review May 10, 2020 07:27
@arturcic arturcic merged commit b4739a4 into GitTools:master May 10, 2020
@arturcic arturcic deleted the feature/validate-artifacts branch May 10, 2020 07:29
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13
Copy link
Member

gep13 commented May 10, 2020

@arturcic thanks for the mention. Was good to see how this was implemented!

@asbjornu
Copy link
Member

Fantastic, @arturcic! 👏 ❤️

@arturcic
Copy link
Member Author

@arturcic thanks for the mention. Was good to see how this was implemented!

You're welcome

@arturcic
Copy link
Member Author

Fantastic, @arturcic! 👏 ❤️

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] Validate GitVersion.Commandline and GitVersion.Portable artifacts
3 participants