-
Notifications
You must be signed in to change notification settings - Fork 651
Control when an attempt is made to upload releasenotes.md #1093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| { | ||
| "version": "0.2.0", | ||
| "configurations": [ | ||
| { | ||
| "name": ".NET Core Launch (console)", | ||
| "type": "coreclr", | ||
| "request": "launch", | ||
| "program": "${workspaceRoot}/tools/Cake.CoreCLR/Cake.dll", | ||
| "args": [ | ||
| "${workspaceRoot}/build.cake", | ||
| "--debug", | ||
| "--verbosity=diagnostic" | ||
| ], | ||
| "cwd": "${workspaceRoot}", | ||
| "stopAtEntry": true, | ||
| "externalConsole": false | ||
| } | ||
| ] | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <packages> | ||
| <package id="Cake" version="0.17.0" /> | ||
| <package id="Cake.CoreCLR" version="0.17.0" /> | ||
| </packages> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should anything in the
.vscodefolder be committed?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@asbjornu I wasn't aware of any rule that it shouldn't be. That file is an easy way to share the required launch command for debugging build.cake file in VSCode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, these are the settings for debugging and should be committed (one of the three file:
settings.json,tasks.jsonandlaunch.jsonwhich should be under version control)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@asbjornu See also here, where they are also explicitely excluded in the
.gitignorefileThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pascalberger nice, I can add that to the gitignore file. Just away to sign off for the night though, so if Travis ever finishes, and we are all happy, feel free to merge, and I can fix that later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gep13 Unfortunately a test case, not releated to the release notes, failed on OS X: https://travis-ci.org/GitTools/GitVersion/jobs/177131223.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gep13, @pascalberger: Okay, good to know. I agree that it should be in the
.gitignorejust to make it explicit. 🙂The
set_PriorityClassproblem is hopefully fixed by GitTools/GitTools.Core#38, but we need to get that released somehow. Kind of related to this PR, but for different reasons and another repository. 😄There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mmh, as long as this is not fixed, we can't merge this PR, except by overriding the required status checks. So to cleanly merge this we would need to have the GitTools.Core release and update GitVersion to the new GitTools.Core version in this PR.