Skip to content
This repository was archived by the owner on Jun 27, 2019. It is now read-only.

Improve process helper #38

Merged
merged 6 commits into from
Nov 16, 2016

Conversation

asbjornu
Copy link
Member

@asbjornu asbjornu commented Nov 1, 2016

Checklist

  • I have included examples or tests
  • I have updated the change log
  • I am listed in the CONTRIBUTORS file
  • I have cleaned up the commit history (use rebase and squash)

Changes proposed in this pull request:

This PR wraps the setting of Process.PriorityClass in a try/catch so everything doesn't blow when trying to set it leads to System.ComponentModel.Win32Exception : Success (as @cvpcs is having problems with in GitTools/GitVersion#1070) or System.InvalidOperationException : Cannot process request because the process (2989) has exited (as @mkoertgen is having problems with in GitTools/GitVersion#720).

I think not being able to set the process' priority class does not warrant blowing up. I think not being able to set it (only failing on Mono/Mac it seems) will only lead to the process running at normal priority, which should be fine.

PS: Unfortunately, this PR also changes the EOL in some files, making it appear a much larger change than it actually is. The files had inconsistent line endings in the blob, making it very hard to work with on my Mac.

PPS: I'm not aware of any CONTRIBUTORS file or change log for this repository, which is why I haven't checked those two boxes above.

@GeertvanHorrik
Copy link
Contributor

Too bad GitHub can't ignore non-relevant changes, but this looks good.

@GeertvanHorrik GeertvanHorrik merged commit 82e648d into GitTools:master Nov 16, 2016
@asbjornu asbjornu deleted the feature/process-helper branch November 16, 2016 12:02
@asbjornu
Copy link
Member Author

@GeertvanHorrik: Excellent, thanks! Now we just have to figure out how to get a new version of GitTools.Core published to NuGet. 🤔

@pascalberger
Copy link
Member

@asbjornu @GeertvanHorrik Where are we regarding publishing a new version of the core package? I think it's really important to push this forward so that we can fix the build pipeline in GitVersion and can move on to accept PRs again

@gep13
Copy link
Member

gep13 commented Nov 23, 2016

@pascalberger as per the discussion on Gitter, I think we are waiting to arrange a Skype call with @JakeGinnivan to walk through the current process, and to get it fully documented. If you can help in getting something arranged to facilitate that, I think it would be great!

@JakeGinnivan
Copy link
Contributor

I put a PR up which explains the process on BitBucket. I have also done a release and am getting the builds green again :)

@gep13
Copy link
Member

gep13 commented Nov 26, 2016

@JakeGinnivan sweet!

@asbjornu
Copy link
Member Author

@JakeGinnivan: Fan-tas-tic! 😄 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants