-
Notifications
You must be signed in to change notification settings - Fork 11
Improve process helper #38
Improve process helper #38
Conversation
…ception if its message is "Success".
…yNotFoundException on error code 3.
Too bad GitHub can't ignore non-relevant changes, but this looks good. |
@GeertvanHorrik: Excellent, thanks! Now we just have to figure out how to get a new version of GitTools.Core published to NuGet. 🤔 |
@asbjornu @GeertvanHorrik Where are we regarding publishing a new version of the core package? I think it's really important to push this forward so that we can fix the build pipeline in GitVersion and can move on to accept PRs again |
@pascalberger as per the discussion on Gitter, I think we are waiting to arrange a Skype call with @JakeGinnivan to walk through the current process, and to get it fully documented. If you can help in getting something arranged to facilitate that, I think it would be great! |
I put a PR up which explains the process on BitBucket. I have also done a release and am getting the builds green again :) |
@JakeGinnivan sweet! |
@JakeGinnivan: Fan-tas-tic! 😄 👍 |
Checklist
Changes proposed in this pull request:
This PR wraps the setting of
Process.PriorityClass
in atry
/catch
so everything doesn't blow when trying to set it leads toSystem.ComponentModel.Win32Exception : Success
(as @cvpcs is having problems with in GitTools/GitVersion#1070) orSystem.InvalidOperationException : Cannot process request because the process (2989) has exited
(as @mkoertgen is having problems with in GitTools/GitVersion#720).I think not being able to set the process' priority class does not warrant blowing up. I think not being able to set it (only failing on Mono/Mac it seems) will only lead to the process running at normal priority, which should be fine.
PS: Unfortunately, this PR also changes the EOL in some files, making it appear a much larger change than it actually is. The files had inconsistent line endings in the blob, making it very hard to work with on my Mac.
PPS: I'm not aware of any
CONTRIBUTORS
file or change log for this repository, which is why I haven't checked those two boxes above.