-
Notifications
You must be signed in to change notification settings - Fork 651
StrictFilePathMarshaler must be used on a FilePath #720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Gathering this is on the GitVersionTask only? I wonder if it is another bug/error which is being triggered which stops the task from generating the version number and then causes this. Hopefully the underlying bug will get found via the exe and fixed then this goes away. I might close this issue for now, if anyone hits this then post and we can reopen to investigate. |
I have this error now on a cleanly installed Windows 10 machine with latest stable git and Visual Studio 2015 enterprise. Suggestions how I can narrow it down? |
@andrejohansson It would be nice to know if you use GitVersionTask or |
I'm using the gitversiontask, this is from my csproj file:
Here is the build output from within visual studio;
|
@andrejohansson Could you please do |
@michaelnoonan, @andrejohansson Poke. 😄 |
Hi everyone. I've just had this reoccur, and I realised that repo was still using Unfortunately upon upgrading to use Next time this happens (if ever) I'll be sure to post more details. |
Happy, but sad - it's failed again today! This is now running Interestingly, running a build from the command-line works perfectly, no warnings/errors:
But when running a Rebuild inside of Visual Studio we get this warning:
I don't have much time to investigate further right now, but let me know if there's anything else I can do to help! Mike |
@nulltoken Do you have any idea what might be causing this? |
That reminds me of two ancient issues.
How can one ensure GitVersionTask is actually leveraging the LibGit2Sharp version it's bundled with? |
@michaelnoonan Is this still a problem, or has it vanished in later versions of GitVersion? |
We have had sporadic recurrences of this problem, but I'm hearing less than On Thu, Jun 2, 2016 at 5:49 PM, Asbjørn Ulsberg [email protected]
|
Seems like people are still having a problem with this, since #899 was reported just now. @nulltoken, what do you mean with:
I guess that question is targeted at the CC-ed people @ethomson, @carlosmn, @jamill, and @SimonCropp, but it would be great to figure this one out as it doesn't seem to have vanished even though @michaelnoonan haven't seen it in a while. |
@nulltoken 's question is about whether it's possible that two versions of LibGit2Sharp are somehow loaded at the same time. Since we were not previously strong name signing the library, there's a first-reference-wins sort of race condition for two people loading LibGit2Sharp from the same application domain. So it's possible that one caller loaded LibGit2Sharp v0.19 and then asked to load LibGit2Sharp v0.22. (For instance). But they would have gotten LibGit2Sharp v0.19 instead since the only time version numbers get referenced is when an assembly is strong name signed (which none of them are). It's probably okay that things aren't strong named signed in a lot of scenarios, but if you don't own how libraries get loaded for your entire process (and if you're an MSBuild plugin, you don't) then you can't guarantee that you're really loading the classes that you think you are. We started strong name signing in v0.23. (At the very end of the release, it was one of the last commits merged, which makes me think that your prerelease wouldn't have it.) Now if some other MSBuild extension wants to use LibGit2Sharp v0.19 it will not impact you, you'll have a completely different copy to use. Would you mind upgrading to v0.23 and see if this is gone? |
@ethomson Thanks for the info! We're currently using version 0.23.0-pre20150419160303 of LibGit2Sharp in GitVersion. If you have a later release of it than this, can you please push it to NuGet? 😄 |
Seems that i also see this. For me, it now occurs on some solution after freshly installed VS 2015 Update 3, MSBuild runs fine from the console. Version used is GitVersionTask 3.6.0. gitversion console runs fine. Here is the Build Output from VS
For me this causes the build to fail as i am using Any new insights on this? |
Uninstalling & Reinstalling the Note: Need to close VS before and restart afterwards because of file access issues. |
Update: Had 2 instances of VS open. The first using GitVersionTask 3.5.4, the second (mentioned above) using GitVersionTask 3.6.0. After resolving this from the second VS instance, it started occurring on the first VS instance. Could be VS is sharing loaded assemblies or dll instances of libgit as said above by https://github.com/ethomson in #720 (comment) |
@mkoertgen Seems like there's a new pre-release of LibGit2Sharp now. Could you upgrade to it in a PR so we can test @ethomson's theory? |
Sure. Could take a couple of days as i am on vacation and afk. |
I just ran into this due to mixing 3.6.1 and 3.6.2 in the same solution. |
Sorry, for being late. I'm back now and try to get to this today. |
Hey everyone I have this problem: The "GitVersion" task was not found. Check the following: |
After updating 2 tests were breaking which seemed to be related to proxy settings. In a proxy-less environment, they run fine. The PR build failed because master evolved meanwhile and a merge was needed. Just did that and PR #1024 should now be ready to be merged in. Sorry, for the long delay. |
The Travis CI build still fails at 1 test, i.e.
I am not sure how i can contribute in stabilizing the build to get this issue fixed. Any suggestions @JakeGinnivan ? |
This hits me when I have two different versions of GitVersionTask in the solution packages folder. Closing VS2015 then wiping out both GitVersionTask packages (plus any other packages that have duplicates), open and rebuild. This ensures that the packages folder now only contains the versions that should be there after nuget has restored the current references. Problem solved. |
I stumbled across this thread while searching for some insight to this problem. I believe the problem may be as @roryprimrose indicated. I have a solution where several projects were referencing Looking for the culprit, I noticed As long as any projects had mismatched versions (at least the two versions specified above), I was able to consistently reproduce the problem. |
@forestb, @roryprimrose: If what your experiences are infact the solution to this problem, that would be awesome. Ideas on how we can automate a check for different versions of GitVersion in the same solution? @mkoertgen: I think I have identified the problem with the test in GitTools/GitTools.Core#38. As soon as that's merged, released and upgraded in GitVersion, I hope we can get rid of this and the problem @cvpcs is having in #1070. |
Today I ran into the same issue. Two instances of Visual Studio, each building unrelated sources from different git repos. Unfortunately at the same time on the same machine. |
This issue could be related to a CoreCLR bug: https://github.com/dotnet/coreclr/issues/19654 |
Seems like dotnet/Nerdbank.GitVersioning#216 might be worth looking at. |
After upgrading to LibGit2Sharp version 0.26 in #1713, this problem might be fixed. Can you please try the latest build and report back whether it fixes this problem or not? Please reopen this issue if the problem persists. |
One of our developers was consistently getting this error when building in Visual Studio 2015:
Could not determine assembly version: StrictFilePathMarshaler must be used on a FilePath
I can see some references to this in
libgit2sharp
, and one in #652.The only remedy we could find under pressure was to re-clone the repository.
Unfortunately we needed to keep moving and don't have the repository to reproduce it any more. Hopefully if anyone else gets this error message we can narrow down the root cause.
The text was updated successfully, but these errors were encountered: