Updated to newer pre-release of libgitsharp to see if that could fix …

[mkoertgen]

…#720

cf. #720 (comment)

[asbjornu]

@mkoertgen Thanks for this! But it seems like you haven't compiled or run the tests locally? Either way, this seems to be the problem causing Travis and AppVeyor to fail:

Mocks/MockQueryableCommitLog.cs(6,14): error CS0535: `MockQueryableCommitLog' does not implement interface member `LibGit2Sharp.IQueryableCommitLog.QueryBy(string, LibGit2Sharp.CommitFilter)'
/home/travis/build/GitTools/GitVersion/src/GitVersionCore.Tests/../packages/LibGit2Sharp.0.23.0-pre20160803182831/lib/net40/LibGit2Sharp.dll (Location of the symbol related to previous error)
Mocks/MockRepository.cs(5,14): error CS0535: `MockRepository' does not implement interface member `LibGit2Sharp.IRepository.Checkout(LibGit2Sharp.Tree, System.Collections.Generic.IEnumerable<string>, LibGit2Sharp.CheckoutOptions)'

[mkoertgen]

Oops, sorry about that. I did not think about breaking changes in libgitsharp.

[mkoertgen]

Added new implementations (with throw new NotImplementedException(). 3 tests are failing in teamCity-something. Will look into this.

[mkoertgen]

It looks as if some non-json output is prepended during the PullRequestInTeamCityTest fixture. This breaks the test because result.OutputVariables cannot be evaluated & asserted anymore.

Probably libgit2 now adds some more output...

[mkoertgen]

The test JsonOutputOnBuildServer.BeingOnBuildServerDoesntOverrideOutputJson() is still green. It verifies we get json output in teamcity-mode.

It seems that something in the libgit2 checkout commands add some ouput (Debug + Release).

[mkoertgen]

Tests still failing. Could make the test pass by just stripping output but i am pretty sure that's not what you want. @asbjornu, any guidance on this?

[asbjornu]

@mkoertgen The problem is that the following is written to stdout before the JSON, right?

revparsing refs/heads/pull/5/merge
grabbed ref refs/heads/pull/5/merge, obj 596f42dde6bd0be7ee2c462d50b095552c370c4d
grabbed branch refs/heads/pull/5/merge
branch: refs/heads/pull/5/merge

Since this problem started after upgrading LibGit2Sharp, am I right to assume that it is LibGit2Sharp that writes this to stdout? If so, we should redirect the output from LibGit2Sharp and only output anything from it if GitVersion's output is not JSON and/or there are errors where debug information from LibGit2Sharp could be useful.

[asbjornu]

@mkoertgen Yep, my assumption was correct. @JakeGinnivan found this. I'm sure it's a mistake that LibGit2Sharp would happily merge, given a pull request. Would you be up for providing a PR to LibGit2Sharp for removing those writelines?

[mkoertgen]

Thx for tracing that back. Seems already done libgit2/libgit2sharp#1361

[asbjornu]

@mkoertgen Excellent, now we only need to wait for a new .nupkg. I hope they release one soon! 😃

[mkoertgen]

I updated libgit2sharp. However, that seemed to break 2 other tests

[mkoertgen]

Too bad. The release-note task fails for some reason, cf.: 4.0.0-PullRequest1024.1133.build.1055#L1035.

Note that build.cake was not touched by any commit, though.

[JakeGinnivan]

@mkoertgen just re-triggered it, worked fine.

[mkoertgen]

Thanks @JakeGinnivan. It seems that everything builds fine except the travis osx-build where one test failed. Probably the test-run was just a bit fragile?

[mkoertgen]

Still one test failing on the travis-build:

https://travis-ci.org/GitTools/GitVersion/jobs/166709203#L2277

[asbjornu]

@mkoertgen: Yeah, I'm sorry about that. I was hoping GitTools/GitTools.Core#38 would remedy what you saw in #720, but this looks like a new problem. It might be related, so getting GitTools/GitTools.Core#38 merged, out the door and updated in GitVersion is worth a shot anyway.

However, we're unfortunately kind of stuck without @JakeGinnivan helping to release the packages, because the release process isn't fully automated in all the GitTools repositories yet and it's also not (fully) documented. Sorry! 😞

[asbjornu]

I've restarted the job in hope that the problem is transient.

[JakeGinnivan]

I have updated all the things on master. I will get a new v4 beta out today, let me know how it goes