Skip to content

Console.WriteLines in library #1360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JakeGinnivan opened this issue Sep 6, 2016 · 1 comment
Closed

Console.WriteLines in library #1360

JakeGinnivan opened this issue Sep 6, 2016 · 1 comment

Comments

@JakeGinnivan
Copy link

GitVersion received a PR updating to the latest libgit2sharp pre-release and our tests failed because libgit2sharp is writing to the console. GitTools/GitVersion#1024

See

libgit2sharp/LibGit2Sharp/Commands/Checkout.cs

Line 43 in 500cc96

Console.WriteLine("revparsing {0}", committishOrBranchSpec);

I assume this snuck in?
@shiftkey
Copy link
Contributor

shiftkey commented Sep 6, 2016

Yep - 🔥 them to the ground

txdv added a commit to txdv/libgit2sharp that referenced this issue Sep 6, 2016
@txdv
Remove debugging code from main library code.
28135b0 
Fixes libgit2#1360
@txdv txdv mentioned this issue Sep 6, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shiftkey @JakeGinnivan