-
Notifications
You must be signed in to change notification settings - Fork 654
Remove NoMono #3036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove NoMono #3036
Conversation
Resolve GitToolsGH-2316 by removing the `NoMono` test category.
a70dd86
to
128a17b
Compare
Ok, it seems like we need to await #3002 for this to be successful as a few former |
@asbjornu I think we could release a new version 5.9.0 that contains the nullable fixes I did and then we can merge the PR with the sunset of net48 and net50 - thoughts? |
Are you suggesting to sunset |
No, there are some changes that were merged related to nullability, that one should get a minor version - 5.9. Right after that we can merge the sunset |
Ok, agreed. We need to get a speed on the new CLI that we also want to break in v6, then. 😅 |
Or we can push the CLI to v7.0 to be more in line with the .net version :D |
True, that's also an option. Do we have any other, lower-hanging fruits of breaking changes we want to roll into v6? Or said reversely, which of the issues in the v6 milestone besides new CLI should we postpone to v7? |
I moved those related to CLI to v7, the others should stay in v6 I think, can you check as well? |
Yeah, I agree. |
This was resolved in #3002. |
Resolve #2316 by removing the
NoMono
test category.Description
It may be that we can do without the
NoMono
test category now. This PR tests that assumption.Related Issue
Resolves #2316.
Motivation and Context
If we don't need to filter out tests to run, we shouldn't.
Checklist: