Skip to content

Remove NoMono #3036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

asbjornu
Copy link
Member

@asbjornu asbjornu commented Mar 8, 2022

Resolve #2316 by removing the NoMono test category.

Description

It may be that we can do without the NoMono test category now. This PR tests that assumption.

Related Issue

Resolves #2316.

Motivation and Context

If we don't need to filter out tests to run, we shouldn't.

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Resolve GitToolsGH-2316 by removing the `NoMono` test category.
@asbjornu asbjornu force-pushed the feature/remove-nomono branch from a70dd86 to 128a17b Compare March 8, 2022 19:00
@asbjornu
Copy link
Member Author

asbjornu commented Mar 8, 2022

Ok, it seems like we need to await #3002 for this to be successful as a few former NoMono categorized tests are still failing on net48 on macOS.

@arturcic
Copy link
Member

arturcic commented Mar 9, 2022

@asbjornu I think we could release a new version 5.9.0 that contains the nullable fixes I did and then we can merge the PR with the sunset of net48 and net50 - thoughts?

@asbjornu
Copy link
Member Author

asbjornu commented Mar 9, 2022

Are you suggesting to sunset net48 and net50 in 5.9?

@arturcic
Copy link
Member

arturcic commented Mar 9, 2022

No, there are some changes that were merged related to nullability, that one should get a minor version - 5.9. Right after that we can merge the sunset net48 and net50 into main and that will be version 6.0 as it's a breaking change.

@asbjornu
Copy link
Member Author

asbjornu commented Mar 9, 2022

Ok, agreed. We need to get a speed on the new CLI that we also want to break in v6, then. 😅

@arturcic
Copy link
Member

arturcic commented Mar 9, 2022

Ok, agreed. We need to get a speed on the new CLI that we also want to break in v6, then. 😅

Or we can push the CLI to v7.0 to be more in line with the .net version :D

@asbjornu
Copy link
Member Author

asbjornu commented Mar 9, 2022

True, that's also an option. Do we have any other, lower-hanging fruits of breaking changes we want to roll into v6? Or said reversely, which of the issues in the v6 milestone besides new CLI should we postpone to v7?

@arturcic
Copy link
Member

arturcic commented Mar 9, 2022

True, that's also an option. Do we have any other, lower-hanging fruits of breaking changes we want to roll into v6? Or said reversely, which of the issues in the v6 milestone besides new CLI should we postpone to v7?

I moved those related to CLI to v7, the others should stay in v6 I think, can you check as well?

@asbjornu
Copy link
Member Author

asbjornu commented Mar 9, 2022

Yeah, I agree.

@asbjornu
Copy link
Member Author

This was resolved in #3002.

@asbjornu asbjornu closed this Mar 10, 2022
@asbjornu asbjornu deleted the feature/remove-nomono branch March 10, 2022 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] Remove NoMono categories
2 participants