Skip to content

Remove NoMono #3036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build/build/Tasks/Test/UnitTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ private static void TestProjectForTarget(BuildContext context, FilePath project,

if (string.Equals(framework, Constants.FullFxVersion48))
{
settings.Filter = context.IsRunningOnUnix() ? $"TestCategory!={Constants.NoMono}" : $"TestCategory!={Constants.NoNet48}";
settings.Filter = context.IsRunningOnUnix() ? string.Empty : $"TestCategory!={Constants.NoNet48}";
}

context.DotNetTest(project.FullPath, settings, coverletSettings);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -228,8 +228,6 @@ public void NextVersionCanHavePatch()

[Test]
[MethodImpl(MethodImplOptions.NoInlining)]
[Category(NoMono)]
[Description(NoMonoDescription)]
public void CanWriteOutEffectiveConfiguration()
{
var config = this.configProvider.Provide(this.repoPath);
Expand Down
2 changes: 0 additions & 2 deletions src/GitVersion.Core.Tests/Configuration/Init/InitScenarios.cs
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@ public class InitScenarios : TestBase
public void Setup() => ShouldlyConfiguration.ShouldMatchApprovedDefaults.LocateTestMethodUsingAttribute<TestAttribute>();

[Test]
[Category(NoMono)]
[Description(NoMonoDescription)]
public void CanSetNextVersion()
{
var workingDirectory = RuntimeInformation.IsOSPlatform(OSPlatform.Windows) ? "c:\\proj" : "/proj";
Expand Down
12 changes: 0 additions & 12 deletions src/GitVersion.Core.Tests/Core/GitVersionExecutorTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,6 @@ public void GitPreparerShouldNotFailWhenTargetPathNotInitialized()
}

[Test]
[Category(NoMono)]
[Description(NoMonoDescription)]
public void CacheKeyForWorktree()
{
using var fixture = new EmptyRepositoryFixture();
Expand Down Expand Up @@ -411,8 +409,6 @@ public void WorkingDirectoryWithoutCommits()
}

[Test]
[Category(NoMono)]
[Description(NoMonoDescription)]
public void GetProjectRootDirectoryWorkingDirectoryWithWorktree()
{
using var fixture = new EmptyRepositoryFixture();
Expand Down Expand Up @@ -480,8 +476,6 @@ public void GetDotGitDirectoryNoWorktree()
}

[Test]
[Category(NoMono)]
[Description(NoMonoDescription)]
public void GetDotGitDirectoryWorktree()
{
using var fixture = new EmptyRepositoryFixture();
Expand Down Expand Up @@ -512,8 +506,6 @@ public void GetDotGitDirectoryWorktree()
}

[Test]
[Category(NoMono)]
[Description(NoMonoDescription)]
public void CalculateVersionFromWorktreeHead()
{
// Setup
Expand Down Expand Up @@ -543,8 +535,6 @@ public void CalculateVersionFromWorktreeHead()
}

[Test]
[Category(NoMono)]
[Description(NoMonoDescription)]
public void CalculateVersionVariables_TwoBranchHasSameCommitHeadDetachedAndNotTagged_ThrowException()
{
// Setup
Expand All @@ -571,8 +561,6 @@ public void CalculateVersionVariables_TwoBranchHasSameCommitHeadDetachedAndNotTa
}

[Test]
[Category(NoMono)]
[Description(NoMonoDescription)]
public void CalculateVersionVariables_TwoBranchHasSameCommitHeadDetachedAndTagged_ReturnSemver()
{
// Setup
Expand Down
2 changes: 0 additions & 2 deletions src/GitVersion.Core.Tests/Helpers/TestBase.cs
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@ namespace GitVersion.Core.Tests.Helpers;

public class TestBase
{
protected const string NoMonoDescription = "Won't run on Mono due to source information not being available for ShouldMatchApproved.";
protected const string NoMono = "NoMono";
protected const string NoNet48 = "NoNet48";
public const string MainBranch = "main";

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@ public class WorktreeScenarios : TestBase
{

[Test]
[Category(NoMono)]
[Description(NoMonoDescription)]
public void UseWorktreeRepositoryForVersion()
{
using var fixture = new EmptyRepositoryFixture();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@ public class JsonVersionBuilderTests : TestBase
public void Setup() => ShouldlyConfiguration.ShouldMatchApprovedDefaults.LocateTestMethodUsingAttribute<TestAttribute>();

[Test]
[Category(NoMono)]
[Description(NoMonoDescription)]
public void Json()
{
var semanticVersion = new SemanticVersion
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,6 @@ public void ShouldLogWarningWhenUsingDefaultInformationalVersionInCustomFormat()
}

[Test]
[Category(NoMono)]
[Description(NoMonoDescription)]
public void ProvidesVariablesInContinuousDeliveryModeForPreRelease()
{
var semVer = new SemanticVersion
Expand All @@ -75,8 +73,6 @@ public void ProvidesVariablesInContinuousDeliveryModeForPreRelease()
}

[Test]
[Category(NoMono)]
[Description(NoMonoDescription)]
public void ProvidesVariablesInContinuousDeliveryModeForPreReleaseWithPadding()
{
var semVer = new SemanticVersion
Expand All @@ -102,8 +98,6 @@ public void ProvidesVariablesInContinuousDeliveryModeForPreReleaseWithPadding()
}

[Test]
[Category(NoMono)]
[Description(NoMonoDescription)]
public void ProvidesVariablesInContinuousDeploymentModeForPreRelease()
{
var semVer = new SemanticVersion
Expand All @@ -128,8 +122,6 @@ public void ProvidesVariablesInContinuousDeploymentModeForPreRelease()
}

[Test]
[Category(NoMono)]
[Description(NoMonoDescription)]
public void ProvidesVariablesInContinuousDeliveryModeForStable()
{
var semVer = new SemanticVersion
Expand All @@ -153,8 +145,6 @@ public void ProvidesVariablesInContinuousDeliveryModeForStable()
}

[Test]
[Category(NoMono)]
[Description(NoMonoDescription)]
public void ProvidesVariablesInContinuousDeploymentModeForStable()
{
var semVer = new SemanticVersion
Expand All @@ -178,8 +168,6 @@ public void ProvidesVariablesInContinuousDeploymentModeForStable()
}

[Test]
[Category(NoMono)]
[Description(NoMonoDescription)]
public void ProvidesVariablesInContinuousDeploymentModeForStableWhenCurrentCommitIsTagged()
{
var semVer = new SemanticVersion
Expand Down Expand Up @@ -251,8 +239,6 @@ public void ProvidesVariablesInContinuousDeploymentModeWithTagSetToUseBranchName
}

[Test]
[Category(NoMono)]
[Description(NoMonoDescription)]
public void ProvidesVariablesInContinuousDeliveryModeForFeatureBranch()
{
var semVer = new SemanticVersion
Expand All @@ -278,8 +264,6 @@ public void ProvidesVariablesInContinuousDeliveryModeForFeatureBranch()
}

[Test]
[Category(NoMono)]
[Description(NoMonoDescription)]
public void ProvidesVariablesInContinuousDeliveryModeForFeatureBranchWithCustomAssemblyInfoFormat()
{
var semVer = new SemanticVersion
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,6 @@ public void Setup()
[TestCase("cs")]
[TestCase("fs")]
[TestCase("vb")]
[Category(NoMono)]
[Description(NoMonoDescription)]
public void ShouldCreateAssemblyInfoFileWhenNotExistsAndEnsureAssemblyInfo(string fileExtension)
{
var workingDir = Path.GetTempPath();
Expand All @@ -53,8 +51,6 @@ public void ShouldCreateAssemblyInfoFileWhenNotExistsAndEnsureAssemblyInfo(strin
[TestCase("cs")]
[TestCase("fs")]
[TestCase("vb")]
[Category(NoMono)]
[Description(NoMonoDescription)]
public void ShouldCreateAssemblyInfoFileAtPathWhenNotExistsAndEnsureAssemblyInfo(string fileExtension)
{
var workingDir = Path.GetTempPath();
Expand All @@ -71,8 +67,6 @@ public void ShouldCreateAssemblyInfoFileAtPathWhenNotExistsAndEnsureAssemblyInfo
[TestCase("cs")]
[TestCase("fs")]
[TestCase("vb")]
[Category(NoMono)]
[Description(NoMonoDescription)]
public void ShouldCreateAssemblyInfoFilesAtPathWhenNotExistsAndEnsureAssemblyInfo(string fileExtension)
{
var workingDir = Path.GetTempPath();
Expand Down Expand Up @@ -162,8 +156,6 @@ public void ShouldReplaceAssemblyVersion(string fileExtension, string assemblyFi
[TestCase("cs", "[assembly: AssemblyFileVersion(\"1.0.0.0\")]")]
[TestCase("fs", "[<assembly: AssemblyFileVersion(\"1.0.0.0\")>]")]
[TestCase("vb", "<Assembly: AssemblyFileVersion(\"1.0.0.0\")>")]
[Category(NoMono)]
[Description(NoMonoDescription)]
public void ShouldNotReplaceAssemblyVersionWhenVersionSchemeIsNone(string fileExtension, string assemblyFileContent)
{
var workingDir = Path.GetTempPath();
Expand Down Expand Up @@ -375,8 +367,6 @@ public void ShouldReplaceAssemblyVersionInRelativePathWithVariablesAndWhiteSpace
[TestCase("cs", "[assembly: AssemblyVersion(\"1.0.0.0\")]\r\n[assembly: AssemblyFileVersion(\"1.0.0.0\")]")]
[TestCase("fs", "[<assembly: AssemblyVersion(\"1.0.0.0\")>]\r\n[<assembly: AssemblyFileVersion(\"1.0.0.0\")>]")]
[TestCase("vb", "<Assembly: AssemblyVersion(\"1.0.0.0\")>\r\n<Assembly: AssemblyFileVersion(\"1.0.0.0\")>")]
[Category(NoMono)]
[Description(NoMonoDescription)]
public void ShouldAddAssemblyInformationalVersionWhenUpdatingAssemblyVersionFile(string fileExtension, string assemblyFileContent)
{
var workingDir = Path.GetTempPath();
Expand All @@ -396,8 +386,6 @@ public void ShouldAddAssemblyInformationalVersionWhenUpdatingAssemblyVersionFile
[TestCase("cs", "[assembly: AssemblyVersion(\"1.0.0.0\")]\r\n[assembly: AssemblyFileVersion(\"1.0.0.0\")]\r\n// comment\r\n")]
[TestCase("fs", "[<assembly: AssemblyVersion(\"1.0.0.0\")>]\r\n[<assembly: AssemblyFileVersion(\"1.0.0.0\")>]\r\ndo\r\n()\r\n")]
[TestCase("vb", "<Assembly: AssemblyVersion(\"1.0.0.0\")>\r\n<Assembly: AssemblyFileVersion(\"1.0.0.0\")>\r\n' comment\r\n")]
[Category(NoMono)]
[Description(NoMonoDescription)]
public void Issue1183ShouldAddFSharpAssemblyInformationalVersionBesideOtherAttributes(string fileExtension, string assemblyFileContent)
{
var workingDir = Path.GetTempPath();
Expand All @@ -417,8 +405,6 @@ public void Issue1183ShouldAddFSharpAssemblyInformationalVersionBesideOtherAttri
[TestCase("cs", "[assembly: AssemblyFileVersion(\"1.0.0.0\")]")]
[TestCase("fs", "[<assembly: AssemblyFileVersion(\"1.0.0.0\")>]")]
[TestCase("vb", "<Assembly: AssemblyFileVersion(\"1.0.0.0\")>")]
[Category(NoMono)]
[Description(NoMonoDescription)]
public void ShouldNotAddAssemblyInformationalVersionWhenVersionSchemeIsNone(string fileExtension, string assemblyFileContent)
{
var workingDir = Path.GetTempPath();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@ public class GitVersionInfoGeneratorTests : TestBase
[TestCase("cs")]
[TestCase("fs")]
[TestCase("vb")]
[Category(NoMono)]
[Description(NoMonoDescription)]
public void ShouldCreateFile(string fileExtension)
{
var directory = Path.GetTempPath();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@ public void Setup()
this.projectFileUpdater = new ProjectFileUpdater(this.log, this.fileSystem);
}

[Category(NoMono)]
[Description(NoMonoDescription)]
[TestCase("Microsoft.NET.Sdk")]
[TestCase("Microsoft.NET.Sdk.Worker")]
[TestCase("Microsoft.NET.Sdk.Web")]
Expand Down Expand Up @@ -69,8 +67,6 @@ public void CanUpdateProjectFileWithSdkProjectFileXml(string sdk)
</PropertyGroup>
</Project>
")]
[Category(NoMono)]
[Description(NoMonoDescription)]
public void CannotUpdateProjectFileWithIncorrectProjectSdk(string xml)
{
var canUpdate = projectFileUpdater.CanUpdateProjectFile(XElement.Parse(xml));
Expand All @@ -90,8 +86,6 @@ public void CannotUpdateProjectFileWithIncorrectProjectSdk(string xml)
</PropertyGroup>
</Project>
")]
[Category(NoMono)]
[Description(NoMonoDescription)]
public void CannotUpdateProjectFileWithMissingProjectSdk(string xml)
{
var canUpdate = projectFileUpdater.CanUpdateProjectFile(XElement.Parse(xml));
Expand All @@ -112,8 +106,6 @@ public void CannotUpdateProjectFileWithMissingProjectSdk(string xml)
</PropertyGroup>
</Project>
")]
[Category(NoMono)]
[Description(NoMonoDescription)]
public void CannotUpdateProjectFileWithoutAssemblyInfoGeneration(string xml)
{
var canUpdate = projectFileUpdater.CanUpdateProjectFile(XElement.Parse(xml));
Expand All @@ -129,8 +121,6 @@ public void CannotUpdateProjectFileWithoutAssemblyInfoGeneration(string xml)
<Project Sdk=""Microsoft.NET.Sdk"">
</Project>
")]
[Category(NoMono)]
[Description(NoMonoDescription)]
public void CannotUpdateProjectFileWithoutAPropertyGroup(string xml)
{
var canUpdate = projectFileUpdater.CanUpdateProjectFile(XElement.Parse(xml));
Expand All @@ -150,8 +140,6 @@ public void CannotUpdateProjectFileWithoutAPropertyGroup(string xml)
</PropertyGroup>
</Project>"
)]
[Category(NoMono)]
[Description(NoMonoDescription)]
public void UpdateProjectXmlVersionElementWithStandardXmlInsertsElement(string xml)
{
var variables = this.variableProvider.GetVariablesFor(SemanticVersion.Parse("2.0.0", "v"), new TestEffectiveConfiguration(), false);
Expand Down Expand Up @@ -179,8 +167,6 @@ public void UpdateProjectXmlVersionElementWithStandardXmlInsertsElement(string x
</PropertyGroup>
</Project>"
)]
[Category(NoMono)]
[Description(NoMonoDescription)]
public void UpdateProjectXmlVersionElementWithStandardXmlModifiesElement(string xml)
{
var variables = this.variableProvider.GetVariablesFor(SemanticVersion.Parse("2.0.0", "v"), new TestEffectiveConfiguration(), false);
Expand Down Expand Up @@ -211,8 +197,6 @@ public void UpdateProjectXmlVersionElementWithStandardXmlModifiesElement(string
</PropertyGroup>
</Project>"
)]
[Category(NoMono)]
[Description(NoMonoDescription)]
public void UpdateProjectXmlVersionElementWithDuplicatePropertyGroupsModifiesLastElement(string xml)
{
var variables = this.variableProvider.GetVariablesFor(SemanticVersion.Parse("2.0.0", "v"), new TestEffectiveConfiguration(), false);
Expand Down Expand Up @@ -244,8 +228,6 @@ public void UpdateProjectXmlVersionElementWithDuplicatePropertyGroupsModifiesLas
</PropertyGroup>
</Project>"
)]
[Category(NoMono)]
[Description(NoMonoDescription)]
public void UpdateProjectXmlVersionElementWithMultipleVersionElementsLastOneIsModified(string xml)
{
var variables = this.variableProvider.GetVariablesFor(SemanticVersion.Parse("2.0.0", "v"), new TestEffectiveConfiguration(), false);
Expand All @@ -272,8 +254,6 @@ public void UpdateProjectXmlVersionElementWithMultipleVersionElementsLastOneIsMo
<TargetFramework>netcoreapp3.1</TargetFramework>
</PropertyGroup>
</Project>")]
[Category(NoMono)]
[Description(NoMonoDescription)]
public void UpdateProjectFileAddsVersionToFile(string xml)
{
var fileName = PathHelper.Combine(Path.GetTempPath(), "TestProject.csproj");
Expand Down
4 changes: 0 additions & 4 deletions src/GitVersion.Core.Tests/VersionConverters/WixFileTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@ internal class WixFileTests : TestBase
public void Setup() => ShouldlyConfiguration.ShouldMatchApprovedDefaults.LocateTestMethodUsingAttribute<TestAttribute>();

[Test]
[Category(NoMono)]
[Description(NoMonoDescription)]
public void UpdateWixVersionFile()
{
var workingDir = Path.GetTempPath();
Expand Down Expand Up @@ -60,8 +58,6 @@ public void UpdateWixVersionFile()
}

[Test]
[Category(NoMono)]
[Description(NoMonoDescription)]
public void UpdateWixVersionFileWhenFileAlreadyExists()
{
var workingDir = Path.GetTempPath();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ public void GenerateGitVersionInformationTaskShouldCreateFileInBuildServer()

[Test]
[Category(NoNet48)]
[Category(NoMono)]
public void GenerateGitVersionInformationTaskShouldCreateFileWhenRunWithMsBuild()
{
const string taskName = nameof(GenerateGitVersionInformation);
Expand All @@ -79,7 +78,6 @@ public void GenerateGitVersionInformationTaskShouldCreateFileWhenRunWithMsBuild(

[Test]
[Category(NoNet48)]
[Category(NoMono)]
public void GenerateGitVersionInformationTaskShouldCreateFileWhenRunWithMsBuildInBuildServer()
{
const string taskName = nameof(GenerateGitVersionInformation);
Expand Down
2 changes: 0 additions & 2 deletions src/GitVersion.MsBuild.Tests/Tasks/GetVersionTaskTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@ public void GetVersionTaskShouldReturnVersionOutputVariablesForBuildServer()
[TestCase(nameof(VersionVariables.MajorMinorPatch), "1.2.4")]
[TestCase(nameof(VersionVariables.FullSemVer), "1.2.4+1")]
[Category(NoNet48)]
[Category(NoMono)]
public void GetVersionTaskShouldReturnVersionOutputVariablesWhenRunWithMsBuild(string outputProperty, string version)
{
const string taskName = nameof(GetVersion);
Expand All @@ -83,7 +82,6 @@ public void GetVersionTaskShouldReturnVersionOutputVariablesWhenRunWithMsBuild(s
[TestCase(nameof(VersionVariables.MajorMinorPatch), "1.0.1")]
[TestCase(nameof(VersionVariables.FullSemVer), "1.0.1+1")]
[Category(NoNet48)]
[Category(NoMono)]
public void GetVersionTaskShouldReturnVersionOutputVariablesWhenRunWithMsBuildInBuildServer(string outputProperty, string version)
{
const string taskName = nameof(GetVersion);
Expand Down
Loading