Skip to content

Use v2 of taiki-e/install-action #1356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2024

Conversation

EliahKagan
Copy link
Member

@EliahKagan EliahKagan commented May 6, 2024

Fixes #1355

This switches from major version 1 to major version 2 of taiki-e/install-action to fix the new Windows failure described in #1355.

For consistency, and because it is preferable to use new versions over very old versions provided they are stable and there is no known reason to prefer the much older version, this changes it in both job definitions that use it, even though the problem only occurs in one generated job (the Windows job) from one of the job definitions (the other one does not generate a Windows job).

However, this is not a general GitHub Action upgrading PR. It is intended to make the minimal change, of those that seem both reasonable and non-confusing, to fix that issue and allow CI checks to pass again. Although I think it would be good to use later versions of some other actions, some of which are quite old, I think that automating such upgrades should be considered, and my inclination is to regard that decision beyond the scope of this PR. But see #1357.

As a demonstration that #1355 really does affect his upstream repository and thus needs fixing--since when I originally opened that I had only produced it in my fork--see this failing job in #1357. No corresponding failure happens here, even though the job does run here, because this PR fixes the issue.

@Byron
Copy link
Member

Byron commented May 7, 2024

Thanks a lot for the fix, and for going through such lengths to verify it.

@Byron Byron merged commit 5d1b0af into GitoxideLabs:main May 7, 2024
19 checks passed
@EliahKagan EliahKagan deleted the fix-install-action branch May 7, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI install-action now fails on Windows, can't find .cargo/bin
2 participants