-
-
Notifications
You must be signed in to change notification settings - Fork 579
Fix: empty folder's disappearing when copying #1719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Notes: For folder layers, |
That is correct in the current main branch @Tiger3018, however @Keavon is currently reversing the ordering of those inputs (I'm unsure why) in a branch in someone's fork. For documentation on what the inputs are, you can look at the implementation (here the |
For highlighting and group issues, it only appeared in Mark this PR ready for review. |
TODO: highlight of the copied empty folder will be gone when its parent changes.
!build |
|
This PR is not related to discovered issues formerly, and can be merged |
I'm sorry, I actually still can't figure out what this PR addresses. What was the original issue or todo item? Can you please edit the PR description to mention only that? |
@Keavon I have removed the |
7bf7f92
to
5f4960d
Compare
I'm still not sure precisely what this PR is about but I think it's already solved by the changes made in #1712 so I will close this as it's redundant. |
TODO:
Related: #1452, #1633