Generalize layers as merge nodes to enable adjustment layers #1712

adamgerhant · 2024-03-29T06:51:05Z

Keavon · 2024-03-29T22:42:06Z

!build

github-actions · 2024-03-29T22:44:51Z

📦 Build Complete for `8d57e3d`
https://6b9881c9.graphite.pages.dev

Keavon · 2024-04-20T07:34:41Z

!build

github-actions · 2024-04-20T07:37:56Z

📦 Build Complete for `a60311a`
https://15a60cfc.graphite.pages.dev

Keavon · 2024-04-25T01:05:05Z

!build

github-actions · 2024-04-25T01:15:54Z

📦 Build Complete for `ae37a12`
https://e922ed80.graphite.pages.dev

Keavon · 2024-04-25T01:49:36Z

!build

github-actions · 2024-04-25T01:52:45Z

📦 Build Complete for `5ad7911`
https://0ec64fe0.graphite.pages.dev

Keavon · 2024-04-25T22:05:44Z

!build

github-actions · 2024-04-25T22:08:57Z

📦 Build Complete for `16045f2`
https://80be10ba.graphite.pages.dev

…ments

Keavon · 2024-04-29T01:37:00Z

!build

github-actions · 2024-04-29T01:39:45Z

📦 Build Complete for `c2395ef`
https://781ad8d0.graphite.pages.dev

Keavon · 2024-04-29T06:26:47Z

!build

github-actions · 2024-04-29T06:29:30Z

📦 Build Complete for `76ec270`
https://74ca567c.graphite.pages.dev

Keavon · 2024-04-29T11:08:37Z

!build

github-actions · 2024-04-29T11:11:21Z

📦 Build Complete for `d96db73`
https://8b5107c3.graphite.pages.dev

…tion,

editor/src/messages/portfolio/document/graph_operation/graph_operation_message_handler.rs

editor/src/messages/portfolio/document/graph_operation/utility_types.rs

Keavon

Superb work on this!

0HyperCube force-pushed the adjustment-layers branch from 8d57e3d to d28524b Compare March 29, 2024 23:13

Keavon force-pushed the master branch from fc355cf to 938a688 Compare April 1, 2024 09:09

Keavon force-pushed the adjustment-layers branch from 3dd0948 to 2591d8f Compare April 8, 2024 03:27

Keavon mentioned this pull request Apr 15, 2024

Tracking Issue: Smarter placement of layers into the artboards that bound them #1507

Open

4 tasks

Keavon force-pushed the master branch from ac4a2eb to 7bf7f92 Compare April 20, 2024 09:07

Keavon force-pushed the adjustment-layers branch from 7d02cc6 to ae37a12 Compare April 25, 2024 01:04

Keavon force-pushed the master branch from 7bf7f92 to 5f4960d Compare April 25, 2024 01:06

adamgerhant force-pushed the adjustment-layers branch 3 times, most recently from 7d02cc6 to 5ad7911 Compare April 25, 2024 01:43

adamgerhant marked this pull request as ready for review April 25, 2024 02:15

adamgerhant and others added 9 commits April 26, 2024 15:43

WIP, backward traversal issues

58dd67a

Fix some tool issues

7cbff5d

Remove debugging

54f0b0d

Change some indices

51c61ba

WIP: new artboard node

c290cbd

WIP: add artboard node

e1498f8

WIP: Artboard node and create_artboard

077a1ba

WIP: Artboard node implementation complete

769f3f4

WIP: Artboards input for output node

7be8bcb

adamgerhant added 2 commits April 28, 2024 13:39

Include non layer nodes in UngroupSelectedLayers

52546ee

GroupSelected for all selected nodes, UnGroupSelected position adjust…

c2395ef

…ments

Add grouping for layers in different folders

76ec270

Keavon mentioned this pull request Apr 29, 2024

Fix: empty folder's disappearing when copying #1719

Closed

1 task

Fix hidden layers

d96db73

adamgerhant and others added 7 commits April 29, 2024 18:31

Prevent node from connecting to itself, fix undo automatic node inser…

18449a6

…tion,

Fix undo CreateEmptyFolder, fix grouping nested layer nodes

ebd3f33

Formatting

5409e27

Merge branch 'master' into adjustment-layers

650f6ea

Remove test and check if node is layer from network

531136b

Fix undo group layers

e7ee147

Check off roadmap

febb8d0

Keavon reviewed May 1, 2024

View reviewed changes

editor/src/messages/portfolio/document/graph_operation/graph_operation_message_handler.rs Outdated Show resolved Hide resolved

editor/src/messages/portfolio/document/graph_operation/utility_types.rs Outdated Show resolved Hide resolved

MoveUpstreamSiblingsToChild adjustments

f650566

Keavon reviewed May 1, 2024

View reviewed changes

editor/src/messages/portfolio/document/graph_operation/utility_types.rs Outdated Show resolved Hide resolved

adamgerhant and others added 2 commits April 30, 2024 19:43

Replace tabs with spaces, remove mut from argument

fa2cb39

Final code review pass

ceb3fde

Keavon force-pushed the adjustment-layers branch from f10b58a to ceb3fde Compare May 1, 2024 05:32

Keavon approved these changes May 1, 2024

View reviewed changes

Keavon merged commit 8d83fa7 into GraphiteEditor:master May 1, 2024

Keavon mentioned this pull request May 5, 2024

Code cleanup and refactor for generalized layers #1738

Merged

adamgerhant mentioned this pull request May 5, 2024

Fix duplicate selection when holding Alt and dragging with Select tool #1739

Merged

Keavon mentioned this pull request May 27, 2024

Fix tool drawing start point offset when an artboard has a transform #1763

Merged

adamgerhant deleted the adjustment-layers branch August 16, 2024 19:09

Uh oh!

Generalize layers as merge nodes to enable adjustment layers #1712

Generalize layers as merge nodes to enable adjustment layers #1712

Uh oh!

Conversation

adamgerhant commented Mar 29, 2024

Uh oh!

Keavon commented Mar 29, 2024

Uh oh!

github-actions bot commented Mar 29, 2024

Uh oh!

Keavon commented Apr 20, 2024

Uh oh!

github-actions bot commented Apr 20, 2024

Uh oh!

Keavon commented Apr 25, 2024

Uh oh!

github-actions bot commented Apr 25, 2024

Uh oh!

Keavon commented Apr 25, 2024

Uh oh!

github-actions bot commented Apr 25, 2024

Uh oh!

Keavon commented Apr 25, 2024

Uh oh!

github-actions bot commented Apr 25, 2024

Uh oh!

Keavon commented Apr 29, 2024

Uh oh!

github-actions bot commented Apr 29, 2024

Uh oh!

Keavon commented Apr 29, 2024

Uh oh!

github-actions bot commented Apr 29, 2024

Uh oh!

Keavon commented Apr 29, 2024

Uh oh!

github-actions bot commented Apr 29, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Keavon left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants