Skip to content

Code cleanup and refactor for generalized layers #1738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 5, 2024

Conversation

adamgerhant
Copy link
Collaborator

@adamgerhant adamgerhant commented May 3, 2024

Closes #1510, a follow-up to PR #1712.

Fixes undo bugs by extracting functions into messages. Generalized Copy and Paste for any layer node, and mapped duplicate layers (ctrl+D) to copy and paste.

Refactored Messages:
DocumentMessage::DuplicateSelectedLayers
DocumentMessage::GroupSelectedLayers
DocumentMessage::MoveSelectedLayersTo
DocumentMessage::UngroupSelectedLayers
NodeGraphMessage::DisconnectNodes
NodeGraphMessage::InsertNodeBetween
GraphOperationMessage::MoveSelectedSiblingsToChild
PortfolioMessage::Copy
PortfolioMessage::PasteSerializedData

New Messages:
NodeGraphMessage::DisconnectLayerFromStack
NodeGraphMessage::SetNodePosition
NodeGraphMessage::ShiftUpstream
GraphOperationMessage::AddNodesAsChild
GraphOperationMessage::DisconnectInput
GraphOperationMessage::InsertLayerAtStackIndex
GraphOperationMessage::InsertNodeBetween
GraphOperationMessage::MoveSelectedSiblingsToChild

@Keavon Keavon changed the title Adjustment layers refactor Code cleanup and refactor for generalized layers May 5, 2024
@Keavon Keavon merged commit 4c38568 into master May 5, 2024
2 checks passed
@Keavon Keavon deleted the adjustment-layers-refactor branch May 5, 2024 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make all nodes stackable and generalize layers as stacked Merge nodes
2 participants