Code cleanup and refactor for generalized layers #1738
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1510, a follow-up to PR #1712.
Fixes undo bugs by extracting functions into messages. Generalized Copy and Paste for any layer node, and mapped duplicate layers (ctrl+D) to copy and paste.
Refactored Messages:
DocumentMessage::DuplicateSelectedLayers
DocumentMessage::GroupSelectedLayers
DocumentMessage::MoveSelectedLayersTo
DocumentMessage::UngroupSelectedLayers
NodeGraphMessage::DisconnectNodes
NodeGraphMessage::InsertNodeBetween
GraphOperationMessage::MoveSelectedSiblingsToChild
PortfolioMessage::Copy
PortfolioMessage::PasteSerializedData
New Messages:
NodeGraphMessage::DisconnectLayerFromStack
NodeGraphMessage::SetNodePosition
NodeGraphMessage::ShiftUpstream
GraphOperationMessage::AddNodesAsChild
GraphOperationMessage::DisconnectInput
GraphOperationMessage::InsertLayerAtStackIndex
GraphOperationMessage::InsertNodeBetween
GraphOperationMessage::MoveSelectedSiblingsToChild