-
-
Notifications
You must be signed in to change notification settings - Fork 581
Change flipping to use the joint bounding box of the selection #323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
Latest commit: |
0364b18
|
Status: | ✅ Deploy successful! |
Preview URL: | https://5757404d.graphite-master.pages.dev |
Keavon
reviewed
Jul 31, 2021
Keavon
reviewed
Jul 31, 2021
Keavon
previously approved these changes
Jul 31, 2021
The above bugs arise from their rotated coordinate system when they are created. We'll have to fix that later. |
Keavon
approved these changes
Jul 31, 2021
Keavon
pushed a commit
that referenced
this pull request
Jun 16, 2022
* Change flipping to use the joint bounding box * Fix minor untested changes * Replace unwrap with question mark
Keavon
pushed a commit
that referenced
this pull request
Jul 30, 2023
* Change flipping to use the joint bounding box * Fix minor untested changes * Replace unwrap with question mark
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #316
FlipLayer
message with a newFlipSelectedLayers
message that takes aFlipAxis
enumSelect
ToolMessage
s to use this new messageFlipSelectedLayers
message-1.
along the axis of flipping, and translates it to the same distance on the other side of the axisCaveats
This change is