Repository navigation
Merge train: #571 #570 - #586
Merged
Merged
Conversation
Work in progress, parked when the implementing session stopped. Not yet compiled by CI or reviewed. Part of #424.
… counts Work in progress, parked when the implementing session stopped. Not yet compiled by CI or reviewed. Part of #437.
Testing Library's ByRoleOptions has no exact option; a string name already matches the whole accessible name. tsc rejected the test file, which failed the admin UI build and every job that embeds it.
Base and head share one Cargo target directory so dependencies compile once. Cargo names a workspace member's artifacts without its source path, so the head tree was judged fresh and the head 'build' finished in 0.2 s with the base revision's binary. That binary has no benchmark test, so discovery listed zero tests and the run failed. Worse, a base that also had the harness would have been compared with itself. Each revision now runs cargo clean -p gateway before its build, so only the gateway crate recompiles, and the built test binary is copied into a per-revision work directory so the next clean cannot remove it. A process test pins the clean-then-build order and the per-revision copies.
…enchmark Benchmark the authoritative HTTP policy decision with allocation counts
…discovery Make admin session discovery a single fail-closed decision
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge train for two reviewed, CI-green PRs, merged with plain
--no-ffand no conflict resolutions. When this merges, GitHub marks each PR merged.