Skip to content

Merge train: #571 #570 - #586

Merged
Antnation merged 6 commits into
mainfrom
train/round-3
Oct 20, 2026
Merged

Antnation merged 6 commits into
mainfrom
train/round-3

Conversation

@Antnation

Copy link
Copy Markdown
Contributor

Merge train for two reviewed, CI-green PRs, merged with plain --no-ff and no conflict resolutions. When this merges, GitHub marks each PR merged.

Work in progress, parked when the implementing session stopped. Not yet compiled by CI or reviewed. Part of #424.
… counts

Work in progress, parked when the implementing session stopped. Not yet compiled by CI or reviewed. Part of #437.
Testing Library's ByRoleOptions has no exact option; a string name already
matches the whole accessible name. tsc rejected the test file, which failed
the admin UI build and every job that embeds it.
Base and head share one Cargo target directory so dependencies compile
once. Cargo names a workspace member's artifacts without its source path,
so the head tree was judged fresh and the head 'build' finished in 0.2 s
with the base revision's binary. That binary has no benchmark test, so
discovery listed zero tests and the run failed. Worse, a base that also had
the harness would have been compared with itself.

Each revision now runs cargo clean -p gateway before its build, so only
the gateway crate recompiles, and the built test binary is copied into a
per-revision work directory so the next clean cannot remove it. A process
test pins the clean-then-build order and the per-revision copies.
…enchmark

Benchmark the authoritative HTTP policy decision with allocation counts
…discovery

Make admin session discovery a single fail-closed decision
Copilot AI balanced review requested due to automatic review settings October 20, 2026 15:01

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-20T15:05:32.802046Z d7962d1 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants