Skip to content

Consolidate mid-October dependency updates - #587

Merged
Antnation merged 2 commits into
mainfrom
chore/dependency-refresh-2026-10b
Oct 20, 2026
Merged

Antnation merged 2 commits into
mainfrom
chore/dependency-refresh-2026-10b

Conversation

@Antnation

@Antnation Antnation commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Consolidates the open mid-October Dependabot updates into one reviewable change, and refreshes every reviewed inventory they invalidate in the same PR. Each inventory change is explained below. The Node 26.12.0 image bump is a separate commit because it moves the executable build-tool contract. No advisory ignore, audit level, license allowance, duplicate exception, check or test is added, removed or loosened.

Supersedes #585
Supersedes #584
Supersedes #583
Supersedes #582
Supersedes #581
Supersedes #580
Supersedes #578
Supersedes #577
Supersedes #576
Supersedes #575
Supersedes #574
Supersedes #573

Commits

  1. Consolidate mid-October Cargo, npm and Actions updates: Bump taiki-e/install-action from 2.87.28 to 2.87.29 #574 to Bump vitest from 5.0.3 to 5.0.5 in /admin-ui #585, except Bump rmcp from 2.2.0 to 3.5.1 #579 and Bump node from 26.10.0-bookworm-slim to 26.12.0-bookworm-slim #573.
  2. Move the build-tool contract to Node 26.12.0 and npm 11.20.0: Bump node from 26.10.0-bookworm-slim to 26.12.0-bookworm-slim #573 only, following the executable build-tool contract the same way Move the build-tool contract to Rust 1.99.0 and Node 26.10.0 #549 did. It can be reverted on its own.

What changes

GitHub Actions (#574)

Action From To
taiki-e/install-action f7e5d7c9 (v2, 2.87.26) 1168f681 (v2, 2.87.28)

The SHA is copied from the Dependabot diff, and the # v2 tag comment is kept. I confirmed that the v2.87.28 tag points at that commit. 2.87.27 and 2.87.28 only update the tool manifests for @latest installs. The job still installs exactly cargo-audit@0.22.2 with checksum: true, and build_tools.py check enforces that. No script test pins this SHA.

Cargo (#575, #576, #578, #581), lock only

Crate From To
aws-lc-rs 1.18.1 1.18.2
aws-lc-sys 0.45.0 0.46.0 (AWS-LC 5.7.0 -> 5.11.0)
serde_json 1.0.151 1.0.154
zeroize 1.9.0 1.9.1
rust-embed, rust-embed-impl, rust-embed-utils 8.12.0 8.13.0

Every checksum matches its Dependabot diff. The manifests are unchanged, because aws-lc-rs = "1.18.1", serde_json = "1.0.150" and rust-embed = "8" already admit these versions.

  • aws-lc-rs 1.18.2 / aws-lc-sys 0.46.0 (crypto backend). I read the aws-lc-rs v1.18.2 release notes and the AWS-LC release notes for v5.8.0, v5.9.0, v5.10.0 and v5.11.0. AWS-LC provides the primitives behind rustls and the JWT verification backend. Changes that affect us:

    Changes that do not affect us:

    • The libssl, CLI, system crypto-policy and FIPS changes. aws-lc-sys builds only libcrypto here, and rustls handles TLS.
    • The new minimum system AWS-LC version, because the bundled source is used.
    • wasm32-wasip2/3 support, and the static FIPS, Cranelift and jitterentropy build fixes.

    The resolved feature set (aws-lc-rs: alloc, aws-lc-sys, default, prebuilt-nasm, ring-io, ring-sig-verify; aws-lc-sys: prebuilt-nasm) and the build-dependency set (cc, cmake, dunce, fs_extra, pkg-config) are identical to 1.18.1/0.45.0. bindgen 0.73 is not pulled in. The license expression is unchanged and still within the allowlist.

  • serde_json 1.0.152 to 1.0.154. The workspace enables arbitrary_precision, so the change that matters is serde-rs/json#1346: a JSON -0 read into a Value now keeps its sign. It is written back as -0, and as_f64 returns -0.0, which is what the crate already did without the feature. Previously it collapsed to the integer 0. as_i64() still returns Some(0), but is_u64() is now false for -0. The other changes are a comparison fix for large non-integers against f32::INFINITY, invalid-UTF-8 errors reported at the first bad byte, and preserve_order support on no_std. No gateway source or test uses a JSON -0 literal.

  • zeroize 1.9.1. Zeroizing's Debug now prints Zeroizing { .. } instead of the wrapped value (RustCrypto/utils#1497), so a derived Debug on a struct that holds a secret no longer prints it. The release also avoids double-zeroizing a Vec's initialized elements and fixes a potential uninitialized read in the optimization_barrier fallback.

  • rust-embed 8.13.0. Adds DynRustEmbed, a dyn-compatible trait blanket-implemented for embed types. The gateway uses only #[derive(rust_embed::RustEmbed)] and rust_embed::EmbeddedFile, with no glob import, so no method resolution changes.

  • Lockfile resolution, following Consolidate October dependency updates and clear new npm advisories #550. cargo update -p <crate> --precise <version> (and Dependabot's Bump aws-lc-rs from 1.18.1 to 1.18.2 #575 and Bump rust-embed from 8.12.0 to 8.13.0 #581) also moved ten unrelated windows-sys edges from 0.61.2 back to 0.52.0 or 0.60.2: cap-fs-ext, cap-primitives, errno, nu-ansi-term, quinn-udp, rustix, rustls-platform-verifier, socket2, tempfile and winapi-util. They also re-pointed tempfile's getrandom edge from 0.4.3 to 0.3.4.

    • cargo update -p getrandom@0.3.4 --precise 0.3.4 returns the getrandom edge to 0.4.3, so that edge is cargo-generated and identical to main.
    • The ten windows-sys edges are restored to their exact main values. Every package whose version did not change now has a byte-identical lock entry, so the Cargo.lock diff contains only the seven version and checksum pairs.
    • cargo metadata --locked and cargo update --workspace --locked accept the lockfile unchanged.

npm

Root (#580, #577, #582): Vitest 5.0.5, Wrangler 4.151.0 (still an exact pin; workerd 1.20261012.1, Miniflare 5.20261012.0-beta), and @cloudflare/workers-types ^5.20261015.1.

Admin UI (#585, #584, #583): Vitest 5.0.5, @vitejs/plugin-react 6.1.2 and jsdom 30.1.3.

  • I produced the lockfiles with npm install --package-lock-only --ignore-scripts --before=2026-10-16T00:00:00Z using npm 11.19.1, the pin at that commit. The cutoff is the earliest whole-day cutoff that admits every folded-in version; the newest, vitest 5.0.5, was published 2026-10-15T14:29Z. As a result, no newly selected version is less than about 4.5 days old. For example, workers-types resolves to 5.20261015.1 rather than 5.20261019.1, and Wrangler 4.151.1 to 4.151.3 are excluded.
  • I compared every changed packages entry in both lockfiles with the lockfile on the corresponding Dependabot branch. All 35 new root tarballs and 27 new admin UI tarballs, and every entry, are identical, including integrity and the @vitejs/plugin-react peer range.
  • Miniflare 5.20261012.0-beta still depends on Sharp 0.35.5, past GHSA-wq5f-xc86-pv6w, so no override is needed.
  • npm audit --audit-level=high reports 0 vulnerabilities at every severity in both the root and admin-ui.

Inventory changes and why they are safe

cargo-policy-exceptions.json / deny.toml. The duplicate set is unchanged: 32 names, with no group added or removed. Owners, reasons, remediation and the 2026-12-01 expiries are also unchanged. Two parent names move with their bumps:

  • syn 2.0.119: rust-embed-impl@8.12.0 becomes @8.13.0. It still depends on syn 2, and the reason ("the remaining derive crates still use syn 2") still holds.
  • untrusted 0.7.1: aws-lc-rs@1.18.1 becomes @1.18.2. The reason (AWS-LC and ring/webpki select distinct parsing interfaces) still holds.

deny.toml lists exact skipped versions, not parents, so it is byte-identical. I recomputed the parent lists from cargo metadata --locked --all-features with the computation validate_graph uses. python scripts/cargo_policy.py config and the validate_graph stage pass. No bump was dropped for introducing a duplicate, because none did.

transport-ownership.json. Only graph changes: 44 lines, all package identity and checksum renames for the seven crates above and their dependents' edges. I recomputed it with transport_guard.py's own graph() from locked all-feature metadata and wrote only that record. build_inputs, standalone_benchmarks and all 754 syntax scopes are untouched. I reviewed the exposure diff: every bumped crate has exactly the same resolved features and dependency set as its predecessor, and the workspace dependency records are unchanged.

The syntax stage cannot run here, because gateway/build.rs asserts a Node version this machine does not have. Instead, I compiled gateway/examples/transport_guard.rs unchanged as a standalone crate under the git-ignored target/, using the locked syn 3.0.6, quote 1.0.47, proc-macro2 1.0.107 and sha2 0.11.0, and ran it over the enumeration transport_guard.py builds:

  • On the untouched origin/main tree, it reproduced all 754 committed scope hashes, and compare_scopes found no difference.
  • On this branch, it again reproduced all 754 scopes, owned all 235 enumerated files, and the recomputed graph equals the committed record.

No .rs file changes in this PR. CI's transport_guard.py check (egress-only) is the final check.

npm-script-policy.json and root allowScripts. Wrangler 4.151.0 changes one locked package with an install hook, workerd 1.20261006.1 -> 1.20261012.1. I reviewed it per docs/deployment/npm-lifecycle-policy.md: I fetched both tarballs as data, checked them against the lockfile SHA-512 and read them in memory, with nothing extracted or executed.

  • The published scripts are still only postinstall: node install.js.
  • The file list is identical and there is no binding.gyp.
  • The optional platform dependencies are the same five at the new version.
  • install.js changes only the embedded release date (2026-10-06 to 2026-10-12) and version strings used by its binary check and fallback download. Its sha256 is now d54ab450....

It stays allow: false with the same reason, and allowScripts denies the new exact URL. esbuild (0.28.2) and fsevents (2.3.3) are unchanged. The admin UI inventory (fsevents only) is unchanged. The lifecycle doc's table names the reviewed workerd version.

Node 26.12.0 (#573), separate commit

Tool Before After Source
Node (node, .node-version, both engines.node, both lockfiles' root engines.node, Docker node stage) 26.10.0 26.12.0 #573: node:26.12.0-bookworm-slim@sha256:298992629d69bbd5b2b03ad57094d8e4fcb3a8eeb7c4e25d29de656519568913, copied verbatim from gh pr diff 573. The tag currently resolves to that same index digest.
npm (npm, .npm-version, both engines.npm, both lockfiles' root engines.npm) 11.19.1 11.20.0 Node v26.12.0 bundles npm 11.20.0 according to both https://nodejs.org/dist/index.json (v26.12.0, 2026-10-14, "npm":"11.20.0", not a security release) and deps/npm/package.json at the v26.12.0 tag of nodejs/node. The Docker builder copies npm from the Node image and asserts it against .npm-version.
  • Files: build-tools.json, .node-version, .npm-version, Dockerfile (the node FROM line only; the Node/npm assertions read the version files), both package.json engines, the root packages[""].engines of both lockfiles (no resolution changes), docs/deployment/dependency-controls.md and docs/deployment/npm-lifecycle-policy.md ("currently 11.20.0"). This is the follow-up Move the build-tool contract to Rust 1.99.0 and Node 26.10.0 #549 anticipated.
  • Rust pins, Cargo.lock, workflows and every reviewed inventory are unchanged by this commit.
  • I checked engines with npm's own semver. Every engines.node range in both lockfiles accepts 26.12.0 except @img/sharp-win32-ia32 (^20.9.0), an optional win32/ia32 binary that the Linux x64 and Windows x64 runners never install. It rejects 26.10.0 on main as well. No lockfile package has an engines.npm range that excludes 11.20.0.
  • npm 11.20.0 includes two allowScripts-related fixes: fix(config): avoid exporting persistent allow-scripts npm/cli#9937 stops exporting a persistent allow-scripts setting, and fix(arborist): match allowScripts keys for local paths npm/cli#9929 matches allowScripts keys for local paths. This repo only uses exact registry URLs, and the npm marker fixtures on Linux (supply-chain) and Windows (npm-policy-windows) run on the new pinned npm.

Dropped

  • Bump rmcp from 2.2.0 to 3.5.1 #579 rmcp 2.2.0 -> 3.5.1 (semver-major). Excluded entirely. It is a major MCP SDK upgrade that needs its own review, not a dependency roll-up.
  • Nothing else was dropped. No bump introduced a new duplicate crate.
  • I left newer releases alone because the folded-in Dependabot PRs did not propose them and they are newer than the cutoff: Wrangler 4.151.1 to 4.151.3, workers-types 5.20261016.1 and later, and vitest 5.1.0-beta.1.

Verification

Run locally (Windows; rustc 1.99.0, the rust_production pin, for resolution; Python 3.12; Node 24 with npm 11.19.1, so not the pinned runtime):

  • cargo metadata --locked, and cargo update --workspace --locked (no changes).
  • cargo audit --deny warnings (cargo-audit 0.22.2, 1345 advisories, 439 crates): no findings.
  • python scripts/cargo_policy.py config and the validate_graph stage pass. In test_cargo_policy.py, the 16 non-native tests pass. The native cargo-deny fixtures need the pinned executable, which I did not install here.
  • The standalone transport-guard syntax run described above (754/754 scopes on main and on this branch).
  • test_transport_guard.py: 20/22 pass. The two errors are the Windows symlink-privilege fixture setup (WinError 1314), the same as on main.
  • node scripts/npm-script-policy.mjs check for both projects, and node --test scripts/test-npm-script-policy.mjs (25/25).
  • npm audit --audit-level=high in the root and in admin-ui: 0 vulnerabilities.
  • Admin UI: tsc --noEmit, vite build, and Vitest 5.0.5 with jsdom 30.1.3 (460 tests).
    • The full run passed 460/460 twice. In two runs on a loaded machine, two or three ClusterView tests timed out at 5 s. ClusterView.test.tsx passed 20/20 on all three isolated reruns.
  • Root: Vitest 5.0.5 (13 tests) and tsc --noEmit.
    • For both local installs I used npm ci --ignore-scripts --engine-strict=false, which is local only; nothing from it is committed.
  • python scripts/build_tools.py check on both commits, plus test_build_tools.py (23), test_security_mutations_workflows.py, test_image_publication.py, test_candidate_scan.py, test_image_evidence.py, test_security_gates.py and scripts/check-supply-chain.py.

The gateway compile and tests, the in-crate transport-guard syntax stage, native cargo-deny on Linux and Windows, the npm marker fixtures on Node 26.12.0 / npm 11.20.0, and the Docker build cannot run here, because gateway/build.rs enforces the Node pin. CI ran them; see below.

CI evidence

The branch was rebased onto main at 3d43cd4 (#586, #570 and #571), which changed no dependency input. On the rebased head a630ea7fbdc11aa2424ff7e2701860f6f37779ed, run 39449926914 passed all 31 checks on its first attempt. The pre-rebase head 8b57e2b had also passed all 31 in run 39446824827; neither run needed a rerun. The passing checks include every required context: fmt, clippy, test, postgres-foundation, admin-ui, cloudflare, egress-only, audit, gitleaks, connections-acceptance, dev-traffic-smoke, ha-compose-example, the 8 ha-release-gate legs, security-coverage, supply-chain (including dependency review), both cargo-policy legs, npm-policy-windows, production-compiler and image-publication. Build image, microbench, security-corpus and operational-alerts also pass. The image-candidate, scan, verification and promotion jobs are skipped, as on every PR.

What the logs show (from the first run, same content):

  • Node and npm. admin-ui, npm-policy-windows, production-compiler and supply-chain print node 26.12.0 and npm 11.20.0. The npm lifecycle policy, the clean installs with hooks denied and the npm marker fixtures pass on that npm. In admin-ui and on Windows, 38 admin UI test files pass, cloudflare passes 2 root test files, and npm audit reports 0 vulnerabilities in both projects.
  • Docker image. Build image uses FROM docker.io/library/node:26.12.0-bookworm-slim@sha256:298992629d69bbd5b2b03ad57094d8e4fcb3a8eeb7c4e25d29de656519568913, and the in-image Node/npm/rustc assertion passes (rustc 1.99.0).
  • Transport guard. egress-only: transport_guard.py check reports {"status": "passed", "stage": "complete", "files": 235, "scopes": 754, "packages": 439, ...}.
  • cargo audit. audit uses cargo-audit 0.22.2, installed through the new install-action pin with checksum verification, scans 439 crates and reports no findings.
  • Gateway tests. test, with rustc 1.98.1, passes 2942 tests on the rebased head (2940 before the rebase) with 0 failures under aws-lc-rs 1.18.2, serde_json 1.0.154, zeroize 1.9.1 and rust-embed 8.13.0.

Copilot AI balanced review requested due to automatic review settings October 20, 2026 15:16

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-20T15:18:49.027832Z 8b57e2b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Folds in the open Dependabot updates so they land as one reviewed change
with the inventories they invalidate.

Cargo (lock only): aws-lc-rs 1.18.2 with aws-lc-sys 0.46.0 (AWS-LC 5.11.0),
serde_json 1.0.154, zeroize 1.9.1 and rust-embed 8.13.0. Each checksum
matches the Dependabot diff. cargo update also re-pointed ten unrelated
windows-sys edges from 0.61.2 to 0.52.0/0.60.2 and tempfile's getrandom
edge from 0.4.3 to 0.3.4; those are restored to main's values (the
getrandom one by cargo itself), so each bump changes only its own version
and checksum. cargo metadata --locked and cargo update --workspace
--locked accept the result unchanged.

npm: root takes Wrangler 4.151.0 (exact pin), Vitest 5.0.5 and
@cloudflare/workers-types 5.20261015.1; the admin UI takes Vitest 5.0.5,
@vitejs/plugin-react 6.1.2 and jsdom 30.1.3. Lockfiles were resolved with
npm install --package-lock-only --ignore-scripts
--before=2026-10-16T00:00:00Z, the earliest whole-day cutoff that admits
every folded-in version; every changed lock entry equals the Dependabot
branch's entry.

Actions: taiki-e/install-action 2.87.28, SHA from the Dependabot diff with
the tag comment kept.

Inventories: cargo-policy-exceptions.json renames two parents
(rust-embed-impl 8.13.0 under syn 2, aws-lc-rs 1.18.2 under untrusted
0.7.1); deny.toml is unchanged. transport-ownership.json's graph is
recomputed with transport_guard.graph(); only version and checksum
renames, with identical features and dependency sets. workerd
1.20261012.1's install.js was fetched as data, checked against the
lockfile SHA-512 and differs only in its embedded release date and
version strings; it stays denied, and allowScripts names the new URL.
Folds in Dependabot's node:26.12.0-bookworm-slim image bump (#573), with
the index digest taken verbatim from its diff (the tag still resolves to
the same digest), and moves every consumer of the executable build-tool
contract with it, as the Node 26.10.0 move did. Otherwise
scripts/build_tools.py, gateway/build.rs, the npm lifecycle installer and
the Dockerfile's own version assertions would disagree.

Node 26.12.0 bundles npm 11.20.0, not 11.19.1, according to both
nodejs.org/dist/index.json and deps/npm/package.json at the v26.12.0 tag of
nodejs/node. The Dockerfile copies npm from the Node image and asserts it
against .npm-version, so npm moves too:

- build-tools.json: node 26.12.0, npm 11.20.0.
- .node-version 26.12.0 and .npm-version 11.20.0.
- engines in both package.json files and in the root package entry of
  both lockfiles (engines only, no resolution changes).
- Dockerfile: the node stage FROM line.
- dependency-controls.md and npm-lifecycle-policy.md state the new
  versions.

Checked with npm's own semver, every engines.node range in both lockfiles
accepts 26.12.0 except @img/sharp-win32-ia32 (^20.9.0), an optional
win32/ia32 binary that no runner installs; it rejects 26.10.0 as well.
No lockfile package declares an engines.npm range that excludes 11.20.0.
Rust pins, Cargo.lock and every reviewed inventory are unchanged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants