Repository navigation
Consolidate mid-October dependency updates - #587
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Folds in the open Dependabot updates so they land as one reviewed change with the inventories they invalidate. Cargo (lock only): aws-lc-rs 1.18.2 with aws-lc-sys 0.46.0 (AWS-LC 5.11.0), serde_json 1.0.154, zeroize 1.9.1 and rust-embed 8.13.0. Each checksum matches the Dependabot diff. cargo update also re-pointed ten unrelated windows-sys edges from 0.61.2 to 0.52.0/0.60.2 and tempfile's getrandom edge from 0.4.3 to 0.3.4; those are restored to main's values (the getrandom one by cargo itself), so each bump changes only its own version and checksum. cargo metadata --locked and cargo update --workspace --locked accept the result unchanged. npm: root takes Wrangler 4.151.0 (exact pin), Vitest 5.0.5 and @cloudflare/workers-types 5.20261015.1; the admin UI takes Vitest 5.0.5, @vitejs/plugin-react 6.1.2 and jsdom 30.1.3. Lockfiles were resolved with npm install --package-lock-only --ignore-scripts --before=2026-10-16T00:00:00Z, the earliest whole-day cutoff that admits every folded-in version; every changed lock entry equals the Dependabot branch's entry. Actions: taiki-e/install-action 2.87.28, SHA from the Dependabot diff with the tag comment kept. Inventories: cargo-policy-exceptions.json renames two parents (rust-embed-impl 8.13.0 under syn 2, aws-lc-rs 1.18.2 under untrusted 0.7.1); deny.toml is unchanged. transport-ownership.json's graph is recomputed with transport_guard.graph(); only version and checksum renames, with identical features and dependency sets. workerd 1.20261012.1's install.js was fetched as data, checked against the lockfile SHA-512 and differs only in its embedded release date and version strings; it stays denied, and allowScripts names the new URL.
Folds in Dependabot's node:26.12.0-bookworm-slim image bump (#573), with the index digest taken verbatim from its diff (the tag still resolves to the same digest), and moves every consumer of the executable build-tool contract with it, as the Node 26.10.0 move did. Otherwise scripts/build_tools.py, gateway/build.rs, the npm lifecycle installer and the Dockerfile's own version assertions would disagree. Node 26.12.0 bundles npm 11.20.0, not 11.19.1, according to both nodejs.org/dist/index.json and deps/npm/package.json at the v26.12.0 tag of nodejs/node. The Dockerfile copies npm from the Node image and asserts it against .npm-version, so npm moves too: - build-tools.json: node 26.12.0, npm 11.20.0. - .node-version 26.12.0 and .npm-version 11.20.0. - engines in both package.json files and in the root package entry of both lockfiles (engines only, no resolution changes). - Dockerfile: the node stage FROM line. - dependency-controls.md and npm-lifecycle-policy.md state the new versions. Checked with npm's own semver, every engines.node range in both lockfiles accepts 26.12.0 except @img/sharp-win32-ia32 (^20.9.0), an optional win32/ia32 binary that no runner installs; it rejects 26.10.0 as well. No lockfile package declares an engines.npm range that excludes 11.20.0. Rust pins, Cargo.lock and every reviewed inventory are unchanged.
Antnation
force-pushed
the
chore/dependency-refresh-2026-10b
branch
from
October 20, 2026 15:36
8b57e2b to
a630ea7
Compare
This was referenced Oct 20, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidates the open mid-October Dependabot updates into one reviewable change, and refreshes every reviewed inventory they invalidate in the same PR. Each inventory change is explained below. The Node 26.12.0 image bump is a separate commit because it moves the executable build-tool contract. No advisory ignore, audit level, license allowance, duplicate exception, check or test is added, removed or loosened.
Supersedes #585
Supersedes #584
Supersedes #583
Supersedes #582
Supersedes #581
Supersedes #580
Supersedes #578
Supersedes #577
Supersedes #576
Supersedes #575
Supersedes #574
Supersedes #573
Commits
Consolidate mid-October Cargo, npm and Actions updates: Bump taiki-e/install-action from 2.87.28 to 2.87.29 #574 to Bump vitest from 5.0.3 to 5.0.5 in /admin-ui #585, except Bump rmcp from 2.2.0 to 3.5.1 #579 and Bump node from 26.10.0-bookworm-slim to 26.12.0-bookworm-slim #573.Move the build-tool contract to Node 26.12.0 and npm 11.20.0: Bump node from 26.10.0-bookworm-slim to 26.12.0-bookworm-slim #573 only, following the executable build-tool contract the same way Move the build-tool contract to Rust 1.99.0 and Node 26.10.0 #549 did. It can be reverted on its own.What changes
GitHub Actions (#574)
f7e5d7c9(v2, 2.87.26)1168f681(v2, 2.87.28)The SHA is copied from the Dependabot diff, and the
# v2tag comment is kept. I confirmed that thev2.87.28tag points at that commit. 2.87.27 and 2.87.28 only update the tool manifests for@latestinstalls. The job still installs exactlycargo-audit@0.22.2withchecksum: true, andbuild_tools.py checkenforces that. No script test pins this SHA.Cargo (#575, #576, #578, #581), lock only
Every checksum matches its Dependabot diff. The manifests are unchanged, because
aws-lc-rs = "1.18.1",serde_json = "1.0.150"andrust-embed = "8"already admit these versions.aws-lc-rs 1.18.2 / aws-lc-sys 0.46.0 (crypto backend). I read the aws-lc-rs v1.18.2 release notes and the AWS-LC release notes for v5.8.0, v5.9.0, v5.10.0 and v5.11.0. AWS-LC provides the primitives behind rustls and the JWT verification backend. Changes that affect us:
[UNIVERSAL 0]end-of-contents parsing, and HMACmd_dataresizing.Changes that do not affect us:
The resolved feature set (
aws-lc-rs: alloc, aws-lc-sys, default, prebuilt-nasm, ring-io, ring-sig-verify;aws-lc-sys: prebuilt-nasm) and the build-dependency set (cc, cmake, dunce, fs_extra, pkg-config) are identical to 1.18.1/0.45.0. bindgen 0.73 is not pulled in. The license expression is unchanged and still within the allowlist.serde_json 1.0.152 to 1.0.154. The workspace enables
arbitrary_precision, so the change that matters is serde-rs/json#1346: a JSON-0read into aValuenow keeps its sign. It is written back as-0, andas_f64returns-0.0, which is what the crate already did without the feature. Previously it collapsed to the integer0.as_i64()still returnsSome(0), butis_u64()is now false for-0. The other changes are a comparison fix for large non-integers againstf32::INFINITY, invalid-UTF-8 errors reported at the first bad byte, andpreserve_ordersupport on no_std. No gateway source or test uses a JSON-0literal.zeroize 1.9.1.
Zeroizing'sDebugnow printsZeroizing { .. }instead of the wrapped value (RustCrypto/utils#1497), so a derivedDebugon a struct that holds a secret no longer prints it. The release also avoids double-zeroizing aVec's initialized elements and fixes a potential uninitialized read in theoptimization_barrierfallback.rust-embed 8.13.0. Adds
DynRustEmbed, a dyn-compatible trait blanket-implemented for embed types. The gateway uses only#[derive(rust_embed::RustEmbed)]andrust_embed::EmbeddedFile, with no glob import, so no method resolution changes.Lockfile resolution, following Consolidate October dependency updates and clear new npm advisories #550.
cargo update -p <crate> --precise <version>(and Dependabot's Bump aws-lc-rs from 1.18.1 to 1.18.2 #575 and Bump rust-embed from 8.12.0 to 8.13.0 #581) also moved ten unrelatedwindows-sysedges from 0.61.2 back to 0.52.0 or 0.60.2: cap-fs-ext, cap-primitives, errno, nu-ansi-term, quinn-udp, rustix, rustls-platform-verifier, socket2, tempfile and winapi-util. They also re-pointed tempfile's getrandom edge from 0.4.3 to 0.3.4.cargo update -p getrandom@0.3.4 --precise 0.3.4returns the getrandom edge to 0.4.3, so that edge is cargo-generated and identical to main.windows-sysedges are restored to their exact main values. Every package whose version did not change now has a byte-identical lock entry, so the Cargo.lock diff contains only the seven version and checksum pairs.cargo metadata --lockedandcargo update --workspace --lockedaccept the lockfile unchanged.npm
Root (#580, #577, #582): Vitest 5.0.5, Wrangler 4.151.0 (still an exact pin; workerd 1.20261012.1, Miniflare 5.20261012.0-beta), and
@cloudflare/workers-types^5.20261015.1.Admin UI (#585, #584, #583): Vitest 5.0.5,
@vitejs/plugin-react6.1.2 and jsdom 30.1.3.npm install --package-lock-only --ignore-scripts --before=2026-10-16T00:00:00Zusing npm 11.19.1, the pin at that commit. The cutoff is the earliest whole-day cutoff that admits every folded-in version; the newest, vitest 5.0.5, was published 2026-10-15T14:29Z. As a result, no newly selected version is less than about 4.5 days old. For example, workers-types resolves to 5.20261015.1 rather than 5.20261019.1, and Wrangler 4.151.1 to 4.151.3 are excluded.packagesentry in both lockfiles with the lockfile on the corresponding Dependabot branch. All 35 new root tarballs and 27 new admin UI tarballs, and every entry, are identical, including integrity and the@vitejs/plugin-reactpeer range.npm audit --audit-level=highreports 0 vulnerabilities at every severity in both the root andadmin-ui.Inventory changes and why they are safe
cargo-policy-exceptions.json/deny.toml. The duplicate set is unchanged: 32 names, with no group added or removed. Owners, reasons, remediation and the 2026-12-01 expiries are also unchanged. Two parent names move with their bumps:rust-embed-impl@8.12.0becomes@8.13.0. It still depends on syn 2, and the reason ("the remaining derive crates still use syn 2") still holds.aws-lc-rs@1.18.1becomes@1.18.2. The reason (AWS-LC and ring/webpki select distinct parsing interfaces) still holds.deny.tomllists exact skipped versions, not parents, so it is byte-identical. I recomputed the parent lists fromcargo metadata --locked --all-featureswith the computationvalidate_graphuses.python scripts/cargo_policy.py configand thevalidate_graphstage pass. No bump was dropped for introducing a duplicate, because none did.transport-ownership.json. Onlygraphchanges: 44 lines, all package identity and checksum renames for the seven crates above and their dependents' edges. I recomputed it withtransport_guard.py's owngraph()from locked all-feature metadata and wrote only that record.build_inputs,standalone_benchmarksand all 754 syntaxscopesare untouched. I reviewed the exposure diff: every bumped crate has exactly the same resolved features and dependency set as its predecessor, and the workspace dependency records are unchanged.The syntax stage cannot run here, because
gateway/build.rsasserts a Node version this machine does not have. Instead, I compiledgateway/examples/transport_guard.rsunchanged as a standalone crate under the git-ignoredtarget/, using the locked syn 3.0.6, quote 1.0.47, proc-macro2 1.0.107 and sha2 0.11.0, and ran it over the enumerationtransport_guard.pybuilds:origin/maintree, it reproduced all 754 committed scope hashes, andcompare_scopesfound no difference.No
.rsfile changes in this PR. CI'stransport_guard.py check(egress-only) is the final check.npm-script-policy.jsonand rootallowScripts. Wrangler 4.151.0 changes one locked package with an install hook, workerd 1.20261006.1 -> 1.20261012.1. I reviewed it perdocs/deployment/npm-lifecycle-policy.md: I fetched both tarballs as data, checked them against the lockfile SHA-512 and read them in memory, with nothing extracted or executed.postinstall: node install.js.binding.gyp.install.jschanges only the embedded release date (2026-10-06to2026-10-12) and version strings used by its binary check and fallback download. Its sha256 is nowd54ab450....It stays
allow: falsewith the same reason, andallowScriptsdenies the new exact URL. esbuild (0.28.2) and fsevents (2.3.3) are unchanged. The admin UI inventory (fsevents only) is unchanged. The lifecycle doc's table names the reviewed workerd version.Node 26.12.0 (#573), separate commit
node,.node-version, bothengines.node, both lockfiles' rootengines.node, Docker node stage)node:26.12.0-bookworm-slim@sha256:298992629d69bbd5b2b03ad57094d8e4fcb3a8eeb7c4e25d29de656519568913, copied verbatim fromgh pr diff 573. The tag currently resolves to that same index digest.npm,.npm-version, bothengines.npm, both lockfiles' rootengines.npm)https://nodejs.org/dist/index.json(v26.12.0, 2026-10-14,"npm":"11.20.0", not a security release) anddeps/npm/package.jsonat thev26.12.0tag of nodejs/node. The Docker builder copies npm from the Node image and asserts it against.npm-version.build-tools.json,.node-version,.npm-version,Dockerfile(the nodeFROMline only; the Node/npm assertions read the version files), bothpackage.jsonengines, the rootpackages[""].enginesof both lockfiles (no resolution changes),docs/deployment/dependency-controls.mdanddocs/deployment/npm-lifecycle-policy.md("currently 11.20.0"). This is the follow-up Move the build-tool contract to Rust 1.99.0 and Node 26.10.0 #549 anticipated.semver. Everyengines.noderange in both lockfiles accepts 26.12.0 except@img/sharp-win32-ia32(^20.9.0), an optional win32/ia32 binary that the Linux x64 and Windows x64 runners never install. It rejects 26.10.0 on main as well. No lockfile package has anengines.npmrange that excludes 11.20.0.supply-chain) and Windows (npm-policy-windows) run on the new pinned npm.Dropped
Verification
Run locally (Windows; rustc 1.99.0, the
rust_productionpin, for resolution; Python 3.12; Node 24 with npm 11.19.1, so not the pinned runtime):cargo metadata --locked, andcargo update --workspace --locked(no changes).cargo audit --deny warnings(cargo-audit 0.22.2, 1345 advisories, 439 crates): no findings.python scripts/cargo_policy.py configand thevalidate_graphstage pass. Intest_cargo_policy.py, the 16 non-native tests pass. The native cargo-deny fixtures need the pinned executable, which I did not install here.test_transport_guard.py: 20/22 pass. The two errors are the Windows symlink-privilege fixture setup (WinError 1314), the same as on main.node scripts/npm-script-policy.mjs checkfor both projects, andnode --test scripts/test-npm-script-policy.mjs(25/25).npm audit --audit-level=highin the root and inadmin-ui: 0 vulnerabilities.tsc --noEmit,vite build, and Vitest 5.0.5 with jsdom 30.1.3 (460 tests).ClusterViewtests timed out at 5 s.ClusterView.test.tsxpassed 20/20 on all three isolated reruns.tsc --noEmit.npm ci --ignore-scripts --engine-strict=false, which is local only; nothing from it is committed.python scripts/build_tools.py checkon both commits, plustest_build_tools.py(23),test_security_mutations_workflows.py,test_image_publication.py,test_candidate_scan.py,test_image_evidence.py,test_security_gates.pyandscripts/check-supply-chain.py.The gateway compile and tests, the in-crate transport-guard syntax stage, native cargo-deny on Linux and Windows, the npm marker fixtures on Node 26.12.0 / npm 11.20.0, and the Docker build cannot run here, because
gateway/build.rsenforces the Node pin. CI ran them; see below.CI evidence
The branch was rebased onto
mainat3d43cd4(#586, #570 and #571), which changed no dependency input. On the rebased heada630ea7fbdc11aa2424ff7e2701860f6f37779ed, run 39449926914 passed all 31 checks on its first attempt. The pre-rebase head8b57e2bhad also passed all 31 in run 39446824827; neither run needed a rerun. The passing checks include every required context: fmt, clippy, test, postgres-foundation, admin-ui, cloudflare, egress-only, audit, gitleaks, connections-acceptance, dev-traffic-smoke, ha-compose-example, the 8 ha-release-gate legs, security-coverage, supply-chain (including dependency review), both cargo-policy legs, npm-policy-windows, production-compiler and image-publication. Build image, microbench, security-corpus and operational-alerts also pass. The image-candidate, scan, verification and promotion jobs are skipped, as on every PR.What the logs show (from the first run, same content):
admin-ui,npm-policy-windows,production-compilerandsupply-chainprintnode 26.12.0andnpm 11.20.0. The npm lifecycle policy, the clean installs with hooks denied and the npm marker fixtures pass on that npm. Inadmin-uiand on Windows, 38 admin UI test files pass,cloudflarepasses 2 root test files, andnpm auditreports 0 vulnerabilities in both projects.Build imageusesFROM docker.io/library/node:26.12.0-bookworm-slim@sha256:298992629d69bbd5b2b03ad57094d8e4fcb3a8eeb7c4e25d29de656519568913, and the in-image Node/npm/rustc assertion passes (rustc 1.99.0).egress-only:transport_guard.py checkreports{"status": "passed", "stage": "complete", "files": 235, "scopes": 754, "packages": 439, ...}.audituses cargo-audit 0.22.2, installed through the new install-action pin with checksum verification, scans 439 crates and reports no findings.test, with rustc 1.98.1, passes 2942 tests on the rebased head (2940 before the rebase) with 0 failures under aws-lc-rs 1.18.2, serde_json 1.0.154, zeroize 1.9.1 and rust-embed 8.13.0.