Skip to content

feat: remove region id and add request header#101

Merged
MichaelScofield merged 5 commits intomainfrom
tweak-proto
Sep 6, 2023
Merged

feat: remove region id and add request header#101
MichaelScofield merged 5 commits intomainfrom
tweak-proto

Conversation

@waynexia
Copy link
Copy Markdown
Member

@waynexia waynexia commented Sep 6, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

  • remove all unnecessary region_id field
  • add request header to query request

Checklist

  • I have written the necessary comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Copy link
Copy Markdown
Contributor

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants