Skip to content

refactor(index): add base offset to InvertedIndexMeta#124

Merged
waynexia merged 4 commits intoGreptimeTeam:mainfrom
zhongzc:zhongzc/inverted-index-base-offset
Nov 24, 2023
Merged

refactor(index): add base offset to InvertedIndexMeta#124
waynexia merged 4 commits intoGreptimeTeam:mainfrom
zhongzc:zhongzc/inverted-index-base-offset

Conversation

@zhongzc
Copy link
Copy Markdown
Contributor

@zhongzc zhongzc commented Nov 23, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

  • Introduction of a base_offset field in the InvertedIndexMeta message. This field specifies the starting byte offset for a tag's inverted index data within the blob. All subsequent offsets in the message are relative to this base_offset.
  • Replacement of absolute offset fields with relative offset fields for the FST data and null bitmap, namely relative_fst_offset and relative_null_bitmap_offset.

Checklist

  • I have written the necessary comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Comment thread proto/greptime/v1/index/inverted_index.proto Outdated
Co-authored-by: Ruihang Xia <waynestxia@gmail.com>
@waynexia waynexia enabled auto-merge (squash) November 24, 2023 08:24
@zhongzc
Copy link
Copy Markdown
Contributor Author

zhongzc commented Nov 24, 2023

Only after this PR is merged can GreptimeTeam/greptimedb#2803 be merged. @killme2008 PTAL

@waynexia waynexia merged commit 2b3ae45 into GreptimeTeam:main Nov 24, 2023
@zhongzc zhongzc deleted the zhongzc/inverted-index-base-offset branch November 24, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants