Skip to content

feat(inverted_index): add index reader#2803

Merged
zhongzc merged 7 commits intoGreptimeTeam:developfrom
zhongzc:zhongzc/inverted-index-format
Nov 27, 2023
Merged

feat(inverted_index): add index reader#2803
zhongzc merged 7 commits intoGreptimeTeam:developfrom
zhongzc:zhongzc/inverted-index-format

Conversation

@zhongzc
Copy link
Copy Markdown
Collaborator

@zhongzc zhongzc commented Nov 23, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Introduce the trait InvertedIndexReader and its implementation.

Depends on GreptimeTeam/greptime-proto#124.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

#2705

GreptimeTeam/greptime-proto#124

Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
@zhongzc zhongzc self-assigned this Nov 23, 2023
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 23, 2023

Codecov Report

Merging #2803 (a280cf1) into develop (9e58bba) will decrease coverage by 0.37%.
The diff coverage is 98.51%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2803      +/-   ##
===========================================
- Coverage    84.74%   84.38%   -0.37%     
===========================================
  Files          732      734       +2     
  Lines       114657   114927     +270     
===========================================
- Hits         97168    96983     -185     
- Misses       17489    17944     +455     

Comment thread src/index/src/inverted_index/format/reader/blob.rs
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
@killme2008 killme2008 requested a review from waynexia November 24, 2023 07:52
Copy link
Copy Markdown
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waynexia waynexia added this pull request to the merge queue Nov 24, 2023
@zhongzc zhongzc removed this pull request from the merge queue due to a manual request Nov 24, 2023
@waynexia waynexia added this pull request to the merge queue Nov 24, 2023
@waynexia waynexia removed this pull request from the merge queue due to a manual request Nov 24, 2023
@killme2008 killme2008 added this pull request to the merge queue Nov 24, 2023
@waynexia waynexia removed this pull request from the merge queue due to a manual request Nov 24, 2023
github-merge-queue Bot pushed a commit that referenced this pull request Nov 24, 2023
* feat(inverted_index): add reader

Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>

* fix: toml format

Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>

* chore: add prefix relative_ to the offset parameter

Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>

* docs: add doc comment

Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>

---------

Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Comment thread src/index/src/inverted_index/format.rs Outdated
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
@zhongzc zhongzc enabled auto-merge November 27, 2023 03:22
@zhongzc zhongzc added this pull request to the merge queue Nov 27, 2023
Merged via the queue into GreptimeTeam:develop with commit b3edbef Nov 27, 2023
@zhongzc zhongzc deleted the zhongzc/inverted-index-format branch November 27, 2023 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants