Skip to content

feat: region procedure service#137

Merged
v0y4g3r merged 9 commits intoGreptimeTeam:mainfrom
killme2008:feature/region-procedure-service
Feb 2, 2024
Merged

feat: region procedure service#137
v0y4g3r merged 9 commits intoGreptimeTeam:mainfrom
killme2008:feature/region-procedure-service

Conversation

@killme2008
Copy link
Copy Markdown
Member

@killme2008 killme2008 commented Feb 2, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Changes for GreptimeTeam/greptimedb#3236

Main changes:

  1. Rename SubmitDdlTaskRequest/SubmitDdlTaskResponse to DdlTaskReques / DdlTaskResponse.
  2. Removed DdlTask RPC service, and added ProcedureService instead. Which adds new functions to query procedure state and migrate a table region.

Checklist

  • I have written the necessary comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@killme2008 killme2008 changed the title Feature/region procedure service feat: region procedure service Feb 2, 2024
@killme2008 killme2008 requested review from WenyXu and v0y4g3r February 2, 2024 09:27
Copy link
Copy Markdown
Contributor

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v0y4g3r v0y4g3r merged commit 96f1f04 into GreptimeTeam:main Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants