Skip to content

refactor: re-generate go grpc protobuf#271

Merged
sunng87 merged 1 commit intoGreptimeTeam:mainfrom
daviderli614:chore/update-go-protobuf
Aug 15, 2025
Merged

refactor: re-generate go grpc protobuf#271
sunng87 merged 1 commit intoGreptimeTeam:mainfrom
daviderli614:chore/update-go-protobuf

Conversation

@daviderli614
Copy link
Copy Markdown
Member

@daviderli614 daviderli614 commented Aug 14, 2025

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

#137#114

What's changed and what's your intention?

This change add the --go-grpc_out parameter to generate proto command to ensure proper generation of gRPC service code (*_grpc.pb.go) for proto files containing service definitions.

protoc -I=${PROTO_ROOT} \
       --go-grpc_out=paths=source_relative:${GO_OUTPUT} \
       $(find ./proto/ -type f -iname "*.proto")

Remove unused grpc methods:

  • go/greptime/v1/meta/route_grpc.pb.go
  • go/greptime/v1/meta/ddl_grpc.pb.go

Checklist

  • I have written the necessary comments.
  • I have added the necessary unit tests and integration tests.

Signed-off-by: liyang <daviderli614@gmail.com>
@daviderli614 daviderli614 marked this pull request as ready for review August 14, 2025 17:54
@sunng87 sunng87 enabled auto-merge (squash) August 15, 2025 01:28
@daviderli614 daviderli614 requested review from fengys1996 and removed request for fengys1996 August 15, 2025 02:29
@sunng87 sunng87 merged commit abeefa9 into GreptimeTeam:main Aug 15, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants