Skip to content

feat(promql): add lookback parameter#145

Merged
waynexia merged 2 commits intoGreptimeTeam:mainfrom
etolbakov:parameterize-lookback
Apr 14, 2024
Merged

feat(promql): add lookback parameter#145
waynexia merged 2 commits intoGreptimeTeam:mainfrom
etolbakov:parameterize-lookback

Conversation

@etolbakov
Copy link
Copy Markdown
Contributor

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

add lookback parameter to Prometheus proto declarations

Checklist

  • I have written the necessary comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

GreptimeTeam/greptimedb#3630
GreptimeTeam/greptimedb#3453

@etolbakov
Copy link
Copy Markdown
Contributor Author

@tisonkun could you please check if that's what needed when you have time?

Copy link
Copy Markdown
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tisonkun tisonkun requested a review from waynexia April 14, 2024 03:33
@waynexia waynexia merged commit 04d78b6 into GreptimeTeam:main Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants