feat(promql): parameterize lookback#3630
Conversation
tisonkun
left a comment
There was a problem hiding this comment.
Seems we need some integration tests.
Does this patch still need some changes on the parser side?
|
I think it's more or less ready. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3630 +/- ##
==========================================
- Coverage 85.38% 85.04% -0.34%
==========================================
Files 963 963
Lines 160719 160730 +11
==========================================
- Hits 137231 136700 -531
- Misses 23488 24030 +542 |
tisonkun
left a comment
There was a problem hiding this comment.
Generally looks good. Suggest we convey to the HTTP endpoints so we don't leave more TODOs.
tisonkun
left a comment
There was a problem hiding this comment.
LGTM.
Further update gRPC codepath and lift step param in HTTP param can be follow-ups.
@tisonkun Thank you for the general feedback! I reflected on that and I'd like to spend a bit more time and deliver something useful rather then a half-baked solution. As for grpc change I'll try making adjustment in greptime-proto repo |
|
@etolbakov Cool! You can ping me as a reviewer when you submit a patch there. |
@etolbakov you may update the lock file locally. This should be automatically updated if you're using VSCode or RustRover. Or you can run |
|
Will this patch close #3453? |
waynexia
left a comment
There was a problem hiding this comment.
This is very neat, thanks @etolbakov 🚀
Let's merge this after CI passes.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
#3453
What's changed and what's your intention?
Parameterize
lookbackand allow it to propagate fromTQLChecklist