refactor: avoid unnecessary alloc by using unwrap_or_else#3742
Merged
fengjiachun merged 1 commit intoGreptimeTeam:mainfrom Apr 19, 2024
Merged
Conversation
Collaborator
Author
|
@killme2008 @waynexia @tisonkun |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3742 +/- ##
==========================================
- Coverage 85.46% 85.13% -0.33%
==========================================
Files 966 966
Lines 162498 162506 +8
==========================================
- Hits 138871 138348 -523
- Misses 23627 24158 +531 |
tisonkun
approved these changes
Apr 18, 2024
Collaborator
|
Thank you! |
Collaborator
|
I update the PR title. We're now generating release notes from PR title, so keeping it clear and expressive is important :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
#3453
#3630
What's changed and what's your intention?
improve the implementation by avoid an allocation if the lookback value is provided.
Checklist