Skip to content

feat: change EXPIRE WHEN to EXPIRE AFTER#170

Merged
waynexia merged 5 commits intomainfrom
expire-after
May 27, 2024
Merged

feat: change EXPIRE WHEN to EXPIRE AFTER#170
waynexia merged 5 commits intomainfrom
expire-after

Conversation

@waynexia
Copy link
Copy Markdown
Member

@waynexia waynexia commented May 21, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Change expire_when to expire_after

Checklist

  • I have written the necessary comments.
  • I have added the necessary unit tests and integration tests.

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
waynexia added 4 commits May 21, 2024 20:55
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Copy link
Copy Markdown
Contributor

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waynexia waynexia merged commit 31dd060 into main May 27, 2024
@waynexia waynexia deleted the expire-after branch May 27, 2024 06:40
@waynexia waynexia restored the expire-after branch May 27, 2024 06:48
@waynexia waynexia deleted the expire-after branch July 19, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants