feat: change EXPIRE WHEN to EXPIRE AFTER#4002
Merged
fengjiachun merged 8 commits intoGreptimeTeam:mainfrom May 27, 2024
Merged
Conversation
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
waynexia
requested review from
a team,
MichaelScofield and
zhongzc
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4002 +/- ##
==========================================
- Coverage 85.42% 85.13% -0.30%
==========================================
Files 983 984 +1
Lines 170493 170469 -24
==========================================
- Hits 145652 145132 -520
- Misses 24841 25337 +496 |
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
fengjiachun
requested changes
May 21, 2024
Collaborator
fengjiachun
left a comment
fengjiachun
left a comment
There was a problem hiding this comment.
We also need to update the way parsing expire_after.
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
discord9
approved these changes
May 24, 2024
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
fengjiachun
approved these changes
May 27, 2024
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Co-authored-by: Jeremyhi <jiachun_feng@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
Change expire declaration gramma in
CREATE FLOWfromEXPIRE WHENtoEXPIRE AFTERRelated proto PR GreptimeTeam/greptime-proto#170
Checklist