Skip to content

feat: add granularity and false_positive_rate options for indexes#249

Merged
zhongzc merged 1 commit intomainfrom
zhongzc/bloom-filter-add-options
Jul 2, 2025
Merged

feat: add granularity and false_positive_rate options for indexes#249
zhongzc merged 1 commit intomainfrom
zhongzc/bloom-filter-add-options

Conversation

@zhongzc
Copy link
Copy Markdown
Contributor

@zhongzc zhongzc commented Jun 27, 2025

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

!!! DO NOT LEAVE THIS BLOCK EMPTY !!!

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Summarize your change (mandatory)
  • How does this PR work? Need a brief introduction for the changed logic (optional)
  • Describe clearly one logical change and avoid lazy messages (optional)
  • Describe any limitations of the current code (optional)

Checklist

  • I have written the necessary comments.
  • I have added the necessary unit tests and integration tests.

Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
@zhongzc zhongzc enabled auto-merge (squash) July 2, 2025 06:36
Copy link
Copy Markdown
Contributor

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhongzc zhongzc merged commit ceb1af4 into main Jul 2, 2025
6 checks passed
@zhongzc zhongzc deleted the zhongzc/bloom-filter-add-options branch July 2, 2025 07:00
zhongzc added a commit that referenced this pull request Jul 2, 2025
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
evenyag pushed a commit that referenced this pull request Jul 2, 2025
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants